-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop JSONB mapping of attributes for M2M relations #4663
Drop JSONB mapping of attributes for M2M relations #4663
Conversation
b76d72f
to
793c941
Compare
cbfe8e9
to
90e5a65
Compare
0ac7aa2
to
77bb1f2
Compare
Here is the report for 0e15b38 (NyanKiyoshi/saleor @ product/attributes/mapping) **Found 2 differences!** (click me)
# api.benchmark checkout
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
add billing address to checkout 34 34 20
add shipping to checkout 7 7 0
checkout payment charge 14 14 0
complete checkout 6 6 0
create checkout 48 48 24
# api.benchmark homepage
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
retrieve main menu 5 5 0
retrieve product list 4 4 0
retrieve secondary menu 5 5 0
retrieve shop 2 2 0
# api.benchmark product
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
- product details 13 15 3
# api.benchmark variant
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
- retrieve variant list 15 18 8 |
This comment has been minimized.
This comment has been minimized.
ce1f8cb
to
b97fd99
Compare
b97fd99
to
ec926d3
Compare
b9b407b
to
94a7eab
Compare
We no longer assume the caller ran the proper checks
8376d44
to
58a4bb6
Compare
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #4663 +/- ##
==========================================
- Coverage 91.72% 91.67% -0.05%
==========================================
Files 313 313
Lines 18744 18852 +108
Branches 1849 1851 +2
==========================================
+ Hits 17192 17283 +91
- Misses 1040 1049 +9
- Partials 512 520 +8
Continue to review full report at Codecov.
|
Closes #4643, closes #4674, fixes #4685.
The migrations are automatically tested against all casesSelectAttribute.value
is testedScreenshots
Pull Request Checklist