Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: attributes resolver inCategory and inCollection #4700

Merged
merged 1 commit into from
Sep 27, 2019

Conversation

khalibloo
Copy link
Contributor

I want to merge this change because...
It fixes the InCategory and InCollection filters in the attributes resolver. Fixes #4698

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. GraphQL schema and type definitions are up to date.
  8. Changes are mentioned in the changelog.

Copy link

django-queries commented Aug 29, 2019

Here is the report for fdd787a (khalibloo/saleor @ fix-attrs-resolver)
Base comparison is 0397b33.

No differences were found. (click me)

# api.benchmark checkout
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  add billing address to checkout            	         38	         38	             20
  add shipping to checkout                   	          7	          7	              0
  checkout payment charge                    	         14	         14	              0
  complete checkout                          	          6	          6	              0
  create checkout                            	         52	         52	             24

# api.benchmark homepage
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  retrieve main menu                         	          5	          5	              0
  retrieve product list                      	          4	          4	              0
  retrieve secondary menu                    	          5	          5	              0
  retrieve shop                              	          2	          2	              0

# api.benchmark product
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  product details                            	         15	         15	              3
  retrieve product attributes                	         13	         13	              2

# api.benchmark variant
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  retrieve variant list                      	         18	         18	              8

# api product sorting attributes
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  sort product not having attribute data     	         21	         21	              0

@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #4700 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4700      +/-   ##
=========================================
+ Coverage   91.12%   91.2%   +0.07%     
=========================================
  Files         343     343              
  Lines       20410   20415       +5     
  Branches     1935    1936       +1     
=========================================
+ Hits        18599   18619      +20     
+ Misses       1272    1259      -13     
+ Partials      539     537       -2
Impacted Files Coverage Δ
saleor/graphql/core/mutations.py 92.6% <ø> (ø) ⬆️
saleor/graphql/product/schema.py 100% <ø> (ø) ⬆️
saleor/graphql/product/resolvers.py 97.29% <100%> (+11.81%) ⬆️
saleor/graphql/product/filters.py 92.85% <100%> (+0.78%) ⬆️
saleor/product/models.py 93.77% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0397b33...fdd787a. Read the comment docs.

@NyanKiyoshi NyanKiyoshi self-assigned this Sep 10, 2019
@NyanKiyoshi
Copy link
Member

NyanKiyoshi commented Sep 12, 2019

Hi, @khalibloo! Thanks again for the PR and the time and efforts you put into it. In #4518 we improved the flexibility of the core.

Could you add me as a collaborator to your fork? I would like to apply the proper changes and tests as it would be quicker and less time consuming than explaining in comments!

@NyanKiyoshi NyanKiyoshi added bug graphql Issues related to the GraphQL API in progress labels Sep 12, 2019
@khalibloo
Copy link
Contributor Author

Sure thing, @NyanKiyoshi ! I've added you now.

@NyanKiyoshi
Copy link
Member

Thank you! And thanks again for the work!

@khalibloo
Copy link
Contributor Author

My pleasure :)

@NyanKiyoshi NyanKiyoshi force-pushed the fix-attrs-resolver branch 2 times, most recently from 9d96cce to 90a66e4 Compare September 27, 2019 09:34
@maarcingebala maarcingebala merged commit e44fcd5 into saleor:master Sep 27, 2019
@NyanKiyoshi NyanKiyoshi deleted the fix-attrs-resolver branch September 27, 2019 13:00
@maarcingebala
Copy link
Member

Thanks for your contribution @khalibloo and @NyanKiyoshi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug graphql Issues related to the GraphQL API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attributes filter "InCategory" does not work (graphql)
4 participants