-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: attributes resolver inCategory and inCollection #4700
Conversation
Here is the report for fdd787a (khalibloo/saleor @ fix-attrs-resolver) No differences were found. (click me)
# api.benchmark checkout
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
add billing address to checkout 38 38 20
add shipping to checkout 7 7 0
checkout payment charge 14 14 0
complete checkout 6 6 0
create checkout 52 52 24
# api.benchmark homepage
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
retrieve main menu 5 5 0
retrieve product list 4 4 0
retrieve secondary menu 5 5 0
retrieve shop 2 2 0
# api.benchmark product
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
product details 15 15 3
retrieve product attributes 13 13 2
# api.benchmark variant
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
retrieve variant list 18 18 8
# api product sorting attributes
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
sort product not having attribute data 21 21 0 |
b5160df
to
bbf9a83
Compare
Codecov Report
@@ Coverage Diff @@
## master #4700 +/- ##
=========================================
+ Coverage 91.12% 91.2% +0.07%
=========================================
Files 343 343
Lines 20410 20415 +5
Branches 1935 1936 +1
=========================================
+ Hits 18599 18619 +20
+ Misses 1272 1259 -13
+ Partials 539 537 -2
Continue to review full report at Codecov.
|
bbf9a83
to
6255374
Compare
Hi, @khalibloo! Thanks again for the PR and the time and efforts you put into it. In #4518 we improved the flexibility of the core. Could you add me as a collaborator to your fork? I would like to apply the proper changes and tests as it would be quicker and less time consuming than explaining in comments! |
Sure thing, @NyanKiyoshi ! I've added you now. |
Thank you! And thanks again for the work! |
My pleasure :) |
9d96cce
to
90a66e4
Compare
90a66e4
to
fdd787a
Compare
Thanks for your contribution @khalibloo and @NyanKiyoshi! |
I want to merge this change because...
It fixes the
InCategory
andInCollection
filters in theattributes
resolver. Fixes #4698Pull Request Checklist