Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update order status after fullfilled digital products #4709

Merged
merged 4 commits into from
Sep 3, 2019
Merged

Update order status after fullfilled digital products #4709

merged 4 commits into from
Sep 3, 2019

Conversation

korycins
Copy link
Member

@korycins korycins commented Sep 2, 2019

We don't update order status after the automatic fulfillment of digital products.
Update of order history was missing.

Related to #4682

@korycins korycins self-assigned this Sep 2, 2019
Copy link

django-queries commented Sep 2, 2019

Here is the report for 693f41f (korycins/saleor @ fix/digital_product/update_order_status_after_fillfiled)
Base comparison is 03eb427.

No differences were found. (click me)

# api.benchmark checkout
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  add billing address to checkout     	         34	         34	             20
  add shipping to checkout            	          7	          7	              0
  checkout payment charge             	         14	         14	              0
  complete checkout                   	          6	          6	              0
  create checkout                     	         48	         48	             24

# api.benchmark homepage
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  retrieve main menu                  	          5	          5	              0
  retrieve product list               	          4	          4	              0
  retrieve secondary menu             	          5	          5	              0
  retrieve shop                       	          2	          2	              0

# api.benchmark product
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  product details                     	         13	         13	              3

# api.benchmark variant
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  retrieve variant list               	         15	         15	              8

@codecov
Copy link

codecov bot commented Sep 2, 2019

Codecov Report

Merging #4709 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4709      +/-   ##
==========================================
+ Coverage   91.59%   91.62%   +0.03%     
==========================================
  Files         308      308              
  Lines       18438    18438              
  Branches     1827     1827              
==========================================
+ Hits        16888    16894       +6     
+ Misses       1041     1038       -3     
+ Partials      509      506       -3
Impacted Files Coverage Δ
saleor/order/models.py 90.94% <0%> (+0.78%) ⬆️
saleor/payment/utils.py 92.03% <0%> (+1.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03eb427...693f41f. Read the comment docs.

@maarcingebala maarcingebala merged commit 854bcd3 into saleor:master Sep 3, 2019
@korycins korycins deleted the fix/digital_product/update_order_status_after_fillfiled branch October 22, 2019 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants