Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering: use search in a consistent way #4715

Merged
merged 10 commits into from
Sep 10, 2019

Conversation

fowczarek
Copy link
Member

@fowczarek fowczarek commented Sep 4, 2019

I want to merge this change because:

Screenshots

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. GraphQL schema and type definitions are up to date.
  8. Changes are mentioned in the changelog.

@fowczarek fowczarek added in progress graphql Issues related to the GraphQL API labels Sep 4, 2019
@fowczarek fowczarek self-assigned this Sep 4, 2019
Copy link

django-queries commented Sep 4, 2019

Here is the report for 445d590 (mirumee/saleor @ 4007/use_search_in_consistent_way)
Base comparison is e27a609.

No differences were found. (click me)

# api.benchmark checkout
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  add billing address to checkout     	         34	         34	             20
  add shipping to checkout            	          7	          7	              0
  checkout payment charge             	         14	         14	              0
  complete checkout                   	          6	          6	              0
  create checkout                     	         48	         48	             24

# api.benchmark homepage
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  retrieve main menu                  	          5	          5	              0
  retrieve product list               	          4	          4	              0
  retrieve secondary menu             	          5	          5	              0
  retrieve shop                       	          2	          2	              0

# api.benchmark product
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  product details                     	         13	         13	              3

# api.benchmark variant
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  retrieve variant list               	         15	         15	              8

@codecov
Copy link

codecov bot commented Sep 4, 2019

Codecov Report

Merging #4715 into master will increase coverage by 0.04%.
The diff coverage is 99%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4715      +/-   ##
==========================================
+ Coverage   91.67%   91.72%   +0.04%     
==========================================
  Files         310      313       +3     
  Lines       18659    18744      +85     
  Branches     1847     1849       +2     
==========================================
+ Hits        17106    17192      +86     
+ Misses       1041     1040       -1     
  Partials      512      512
Impacted Files Coverage Δ
saleor/graphql/menu/filters.py 100% <100%> (ø)
saleor/graphql/menu/schema.py 100% <100%> (+3.03%) ⬆️
saleor/graphql/order/filters.py 83.63% <100%> (+2%) ⬆️
saleor/graphql/extensions/filters.py 100% <100%> (ø)
saleor/graphql/utils.py 91.11% <100%> (+0.09%) ⬆️
saleor/extensions/manager.py 88.13% <100%> (ø) ⬆️
saleor/graphql/page/schema.py 100% <100%> (ø) ⬆️
saleor/graphql/extensions/schema.py 100% <100%> (ø) ⬆️
saleor/graphql/product/schema.py 100% <100%> (ø) ⬆️
saleor/graphql/product/filters.py 92.68% <100%> (+0.37%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e27a609...445d590. Read the comment docs.

@fowczarek fowczarek force-pushed the 4007/use_search_in_consistent_way branch from 14f99b2 to 8acf5b2 Compare September 9, 2019 13:06
@fowczarek fowczarek force-pushed the 4007/use_search_in_consistent_way branch from 8acf5b2 to 2bf095f Compare September 9, 2019 13:19
saleor/graphql/order/filters.py Outdated Show resolved Hide resolved
saleor/graphql/order/filters.py Outdated Show resolved Hide resolved
saleor/graphql/utils.py Outdated Show resolved Hide resolved
@fowczarek fowczarek force-pushed the 4007/use_search_in_consistent_way branch from 9adb542 to 445d590 Compare September 10, 2019 07:56
@maarcingebala maarcingebala merged commit c7c1416 into master Sep 10, 2019
@maarcingebala maarcingebala deleted the 4007/use_search_in_consistent_way branch September 10, 2019 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graphql Issues related to the GraphQL API in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend the ProductOrderField Filtering: use search in a consistent way
3 participants