Add redirectUrl to staff and user create mutations #4717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the report for 5ccd99a (mirumee/saleor @ 4716/redirect_url_in_staff_create_mutation) No differences were found. (click me)
# api.benchmark checkout
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
add billing address to checkout 34 34 20
add shipping to checkout 7 7 0
checkout payment charge 14 14 0
complete checkout 6 6 0
create checkout 48 48 24
# api.benchmark homepage
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
retrieve main menu 5 5 0
retrieve product list 4 4 0
retrieve secondary menu 5 5 0
retrieve shop 2 2 0
# api.benchmark product
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
product details 13 13 3
# api.benchmark variant
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
retrieve variant list 15 15 8 |
Codecov Report
@@ Coverage Diff @@
## master #4717 +/- ##
==========================================
+ Coverage 91.63% 91.66% +0.02%
==========================================
Files 310 310
Lines 18633 18659 +26
Branches 1843 1847 +4
==========================================
+ Hits 17075 17104 +29
+ Misses 1045 1042 -3
Partials 513 513
Continue to review full report at Codecov.
|
fowczarek
force-pushed
the
4716/redirect_url_in_staff_create_mutation
branch
from
cee764d
to
d509906
Compare
fowczarek
force-pushed
the
4716/redirect_url_in_staff_create_mutation
branch
from
d509906
to
c249b97
Compare
NyanKiyoshi
reviewed
Sep 5, 2019
| ) | ||
| content = get_graphql_content(response) | ||
| data = content["data"]["customerCreate"] | ||
| assert data["errors"][0]["field"] == "redirectUrl" |
There was a problem hiding this comment.
Comparing the message as well would be better to ensure that's actually the error we were expecting, and to allow developers to search for the associated test
There was a problem hiding this comment.
I hope that today we'll merge #4676 which would allow us to check the error codes in cases like this. Relying on error messages comparisons in tests always feels a little bit clunky to me ;)
| ) | ||
| content = get_graphql_content(response) | ||
| data = content["data"]["customerCreate"] | ||
| assert data["errors"][0]["field"] == "redirectUrl" |
| ) | ||
| content = get_graphql_content(response) | ||
| data = content["data"]["customerCreate"] | ||
| assert data["errors"][0]["field"] == "redirectUrl" |
maarcingebala
approved these changes
Sep 6, 2019
korycins
reviewed
Sep 6, 2019
fowczarek
force-pushed
the
4716/redirect_url_in_staff_create_mutation
branch
from
c112349
to
5ccd99a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to merge this change because resolve #4716
TODO:
Screenshots
Pull Request Checklist