Support for webhooks #4731
Merged
Support for webhooks #4731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the report for 1cb2245 (korycins/saleor @ feature/webhooks) No differences were found. (click me)
# api.benchmark checkout
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
add billing address to checkout 38 38 20
add shipping to checkout 7 7 0
checkout payment charge 14 14 0
complete checkout 6 6 0
create checkout 52 52 24
# api.benchmark homepage
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
retrieve main menu 5 5 0
retrieve product list 4 4 0
retrieve secondary menu 5 5 0
retrieve shop 2 2 0
# api.benchmark product
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
product details 15 15 3
retrieve product attributes 13 13 2
# api.benchmark variant
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
retrieve variant list 18 18 8
# api product sorting attributes
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
sort product not having attribute data 21 21 0 |
Codecov Report
@@ Coverage Diff @@
## master #4731 +/- ##
==========================================
- Coverage 91.21% 91.15% -0.06%
==========================================
Files 330 343 +13
Lines 19906 20371 +465
Branches 1888 1930 +42
==========================================
+ Hits 18157 18569 +412
- Misses 1228 1264 +36
- Partials 521 538 +17
Continue to review full report at Codecov.
|
NyanKiyoshi
reviewed
Sep 10, 2019
NyanKiyoshi
reviewed
Sep 10, 2019
added 18 commits
September 12, 2019 14:43
|
@salwator @NyanKiyoshi @maarcingebala ready for review |
salwator
approved these changes
Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2084
It adds support for Webhooks.
It adds mutation for subscribing, deleting and listing Webhook subscription. Service Account can assign to all events but permissions to given resources are required to trigger webhook event. Webhook logic is written as a Saleor's plugin.