Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translations to countries in shop query #4732

Merged
merged 3 commits into from
Sep 11, 2019

Conversation

fowczarek
Copy link
Member

@fowczarek fowczarek commented Sep 11, 2019

I want to merge this change because resolve #4622

Screenshots

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. GraphQL schema and type definitions are up to date.
  8. Changes are mentioned in the changelog.

@fowczarek fowczarek self-assigned this Sep 11, 2019
Copy link

django-queries commented Sep 11, 2019

Here is the report for 428b753 (mirumee/saleor @ 4622/Add_languagecode_parameter)
Base comparison is 2a6f85b.

No differences were found. (click me)

# api.benchmark checkout
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  add billing address to checkout     	         34	         34	             20
  add shipping to checkout            	          7	          7	              0
  checkout payment charge             	         14	         14	              0
  complete checkout                   	          6	          6	              0
  create checkout                     	         48	         48	             24

# api.benchmark homepage
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  retrieve main menu                  	          5	          5	              0
  retrieve product list               	          4	          4	              0
  retrieve secondary menu             	          5	          5	              0
  retrieve shop                       	          2	          2	              0

# api.benchmark product
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  product details                     	         15	         15	              3

# api.benchmark variant
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  retrieve variant list               	         18	         18	              8

@codecov
Copy link

codecov bot commented Sep 11, 2019

Codecov Report

Merging #4732 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4732      +/-   ##
==========================================
+ Coverage   91.67%   91.67%   +<.01%     
==========================================
  Files         313      313              
  Lines       18852    18855       +3     
  Branches     1851     1851              
==========================================
+ Hits        17283    17286       +3     
  Misses       1049     1049              
  Partials      520      520
Impacted Files Coverage Δ
saleor/graphql/shop/types.py 95.89% <100%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a6f85b...3529a75. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 11, 2019

Codecov Report

Merging #4732 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4732      +/-   ##
==========================================
+ Coverage   91.67%   91.67%   +<.01%     
==========================================
  Files         313      313              
  Lines       18852    18855       +3     
  Branches     1851     1851              
==========================================
+ Hits        17283    17286       +3     
  Misses       1049     1049              
  Partials      520      520
Impacted Files Coverage Δ
saleor/graphql/shop/types.py 95.89% <100%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a6f85b...428b753. Read the comment docs.

@maarcingebala maarcingebala merged commit c42b24f into master Sep 11, 2019
@maarcingebala maarcingebala deleted the 4622/Add_languagecode_parameter branch September 11, 2019 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add languagecode parameter for quering translated countries available in the shop
3 participants