-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide capped stock quantity instead of exact one and restrict the costPrice field productVariant #4753
Provide capped stock quantity instead of exact one and restrict the costPrice field productVariant #4753
Conversation
e047359
to
4a06530
Compare
Here is the report for f9b26ee (NyanKiyoshi/saleor @ fix/variants/stock-permissions) **Found 1 differences!** (click me)
# api.benchmark checkout
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
add billing address to checkout 34 34 20
add shipping to checkout 7 7 0
checkout payment charge 14 14 0
complete checkout 6 6 0
create checkout 48 48 24
# api.benchmark homepage
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
retrieve main menu 5 5 0
retrieve product list 4 4 0
retrieve secondary menu 5 5 0
retrieve shop 2 2 0
# api.benchmark product
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
product details 15 15 3
retrieve product attributes 13 13 2
# api.benchmark variant
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
+ retrieve variant list 18 15 6
# api product sorting attributes
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
sort product not having attribute data 21 21 0 |
Codecov Report
@@ Coverage Diff @@
## master #4753 +/- ##
==========================================
+ Coverage 91.23% 91.25% +0.01%
==========================================
Files 344 344
Lines 20616 20623 +7
Branches 1956 1956
==========================================
+ Hits 18810 18819 +9
+ Misses 1268 1266 -2
Partials 538 538
Continue to review full report at Codecov.
|
I think there should be some way to determine available quantity in the public API. We spoke with @patrys and came up with an idea to:
Also, I was checking if we could use the |
e8db2aa
to
1f6742a
Compare
a1eb268
to
815f2eb
Compare
4d64abe
to
f9b26ee
Compare
Closes #4724.
Screenshots
Pull Request Checklist