-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all static payment settings #4756
Conversation
Here is the report for 078f3d1 (mirumee/saleor @ remove-all-static-payment-settings) No differences were found. (click me)
# api.benchmark checkout
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
add billing address to checkout 38 38 20
add shipping to checkout 7 7 0
checkout payment charge 14 14 0
complete checkout 6 6 0
create checkout 52 52 24
# api.benchmark homepage
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
retrieve main menu 5 5 0
retrieve product list 4 4 0
retrieve secondary menu 5 5 0
retrieve shop 2 2 0
# api.benchmark product
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
product details 15 15 3
retrieve product attributes 13 13 2
# api.benchmark variant
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
retrieve variant list 18 18 8
# api product sorting attributes
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
sort product not having attribute data 21 21 0 |
Codecov Report
@@ Coverage Diff @@
## master #4756 +/- ##
==========================================
- Coverage 91.15% 91.11% -0.05%
==========================================
Files 343 343
Lines 20371 20366 -5
Branches 1930 1930
==========================================
- Hits 18569 18556 -13
- Misses 1264 1272 +8
Partials 538 538
Continue to review full report at Codecov.
|
8e8f002
to
cdb3570
Compare
- Update tests - Serve strings instead of enums in list_available_gateways - Fix imports
028f43f
to
49ed2e6
Compare
Gateway enum was used to pass gateway type in payment interface, right now it is pointless, due to gateways being dynamic plugins. - Remove Gateway enum - Rename payment gateway plugins so naming is consistent in plugins - Align tests
49ed2e6
to
1b24413
Compare
@salwator What about storefront PWA. Are they ready for this change? |
This PR purpose is to remove all remaining static configuration for the payment process and rely entirely on payment plugins configuration. This forces us to abandon payment gateway enum from graphql schema and fetch template_path information from plugin configuration.
Fixes #4748
Roadmap:
Pull Request Checklist