-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add descriptions for queries #4758
Conversation
Here is the report for e5a0141 (maarcingebala/saleor @ graphql-docs) No differences were found. (click me)
# api.benchmark checkout
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
add billing address to checkout 38 38 20
add shipping to checkout 7 7 0
checkout payment charge 14 14 0
complete checkout 6 6 0
create checkout 52 52 24
# api.benchmark homepage
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
retrieve main menu 5 5 0
retrieve product list 4 4 0
retrieve secondary menu 5 5 0
retrieve shop 2 2 0
# api.benchmark product
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
product details 15 15 3
# api.benchmark variant
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
retrieve variant list 18 18 8 |
Codecov Report
@@ Coverage Diff @@
## master #4758 +/- ##
=========================================
Coverage ? 91.21%
=========================================
Files ? 330
Lines ? 19880
Branches ? 1882
=========================================
Hits ? 18134
Misses ? 1227
Partials ? 519
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Happy to see PR from you!
Co-Authored-By: NyanKiyoshi <hello@vanille.bid>
Co-Authored-By: NyanKiyoshi <hello@vanille.bid>
Co-Authored-By: NyanKiyoshi <hello@vanille.bid>
Co-Authored-By: NyanKiyoshi <hello@vanille.bid>
This PR adds descriptions to queries and query arguments. These changes were made when I was working on the initial version of API reference for our docs (saleor/saleor-docs#45). There is still a lot of descriptions to add but I'm planning on doing it in separate PRs)
Pull Request Checklist