-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed crash of sale form when required values are missing #4778
Fixed crash of sale form when required values are missing #4778
Conversation
165c48b
to
e1d8460
Compare
Here is the report for e1d8460 (NyanKiyoshi/saleor @ fix/dashboard-1.0/sales/update/missing-required-fields) No differences were found. (click me)
# api.benchmark checkout
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
add billing address to checkout 38 38 20
add shipping to checkout 7 7 0
checkout payment charge 14 14 0
complete checkout 6 6 0
create checkout 52 52 24
# api.benchmark homepage
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
retrieve main menu 5 5 0
retrieve product list 4 4 0
retrieve secondary menu 5 5 0
retrieve shop 2 2 0
# api.benchmark product
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
product details 15 15 3
retrieve product attributes 13 13 2
# api.benchmark variant
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
retrieve variant list 18 18 8
# api product sorting attributes
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
sort product not having attribute data 21 21 0 |
Codecov Report
@@ Coverage Diff @@
## master #4778 +/- ##
=========================================
+ Coverage 91.2% 91.2% +<.01%
=========================================
Files 343 343
Lines 20415 20417 +2
Branches 1936 1937 +1
=========================================
+ Hits 18619 18621 +2
Misses 1259 1259
Partials 537 537
Continue to review full report at Codecov.
|
@@ -59,6 +59,9 @@ def __init__(self, *args, **kwargs): | |||
|
|||
def clean(self): | |||
cleaned_data = super().clean() | |||
if self.errors: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a big deal, but I think a more common pattern in Django is to use .get
to check if there are cleaned values:
discount_type = cleaned_data.get('type')
value = cleaned_data.get("value")
if type and value:
# stuff
Closes #4697
Screenshots
Pull Request Checklist