-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backend logic for dynamic default email sender settings #4820
Add backend logic for dynamic default email sender settings #4820
Conversation
9535980
to
c9916b7
Compare
Here is the report for d3be77b (NyanKiyoshi/saleor @ dynamic-settings/email-sender) No differences were found. (click me)
# api.benchmark checkout
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
add billing address to checkout 34 34 20
add shipping to checkout 7 7 0
checkout payment charge 14 14 0
complete checkout 6 6 0
create checkout 48 48 24
# api.benchmark homepage
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
retrieve main menu 5 5 0
retrieve product list 4 4 0
retrieve secondary menu 5 5 0
retrieve shop 2 2 0
# api.benchmark product
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
product details 15 15 3
retrieve product attributes 13 13 2
# api.benchmark variant
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
product variant bulk create 51 51 3
retrieve variant list 15 15 6
# api product sorting attributes
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
sort product not having attribute data 21 21 0 |
Codecov Report
@@ Coverage Diff @@
## master #4820 +/- ##
==========================================
- Coverage 91.49% 91.27% -0.23%
==========================================
Files 347 345 -2
Lines 20746 20646 -100
Branches 1971 1958 -13
==========================================
- Hits 18982 18844 -138
- Misses 1220 1264 +44
+ Partials 544 538 -6
Continue to review full report at Codecov.
|
2050e11
to
960a956
Compare
2f27d39
to
45f20c9
Compare
Codecov Report
@@ Coverage Diff @@
## master #4820 +/- ##
==========================================
+ Coverage 91.48% 91.53% +0.04%
==========================================
Files 348 349 +1
Lines 20878 20911 +33
Branches 1993 1995 +2
==========================================
+ Hits 19101 19141 +40
+ Misses 1229 1222 -7
Partials 548 548
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub said I needed to write something here. So... Hello!! Wish you all a great day!
f4fef79
to
b5e404a
Compare
e486d0e
to
ad13b35
Compare
ad13b35
to
d3be77b
Compare
Closes #4815
Definition of Done
send_mail
's own double check)Pull Request Checklist