Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placing an order no longer fails when customer has a duplicated address #4824

Merged
merged 2 commits into from
Oct 9, 2019

Conversation

NyanKiyoshi
Copy link
Member

Closes #4592

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. GraphQL schema and type definitions are up to date.
  8. Changes are mentioned in the changelog.

Copy link

Here is the report for 0b11bc3 (NyanKiyoshi/saleor @ core/unique-addresses)
Base comparison is 977464e.

No differences were found. (click me)

# api.benchmark checkout
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  add billing address to checkout            	         34	         34	             20
  add shipping to checkout                   	          7	          7	              0
  checkout payment charge                    	         14	         14	              0
  complete checkout                          	          6	          6	              0
  create checkout                            	         48	         48	             24

# api.benchmark homepage
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  retrieve main menu                         	          5	          5	              0
  retrieve product list                      	          4	          4	              0
  retrieve secondary menu                    	          5	          5	              0
  retrieve shop                              	          2	          2	              0

# api.benchmark product
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  product details                            	         15	         15	              3
  retrieve product attributes                	         13	         13	              2

# api.benchmark variant
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  retrieve variant list                      	         18	         18	              8

# api product sorting attributes
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  sort product not having attribute data     	         21	         21	              0

@codecov
Copy link

codecov bot commented Oct 8, 2019

Codecov Report

Merging #4824 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4824   +/-   ##
=======================================
  Coverage   91.26%   91.26%           
=======================================
  Files         344      344           
  Lines       20617    20617           
  Branches     1956     1956           
=======================================
  Hits        18817    18817           
  Misses       1263     1263           
  Partials      537      537

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 977464e...0b11bc3. Read the comment docs.

@codecov
Copy link

codecov bot commented Oct 8, 2019

Codecov Report

Merging #4824 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4824      +/-   ##
==========================================
+ Coverage   91.25%   91.26%   +0.01%     
==========================================
  Files         344      344              
  Lines       20623    20617       -6     
  Branches     1956     1956              
==========================================
- Hits        18819    18817       -2     
+ Misses       1266     1263       -3     
+ Partials      538      537       -1
Impacted Files Coverage Δ
saleor/graphql/product/types/products.py 92.55% <0%> (+0.37%) ⬆️
saleor/graphql/order/types.py 90.52% <0%> (+0.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6b06fc...92a96a2. Read the comment docs.

@maarcingebala maarcingebala merged commit d5eb9c7 into saleor:master Oct 9, 2019
@NyanKiyoshi NyanKiyoshi deleted the core/unique-addresses branch October 9, 2019 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Users can create the same address multiple times
3 participants