-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Placing an order no longer fails when customer has a duplicated address #4824
Placing an order no longer fails when customer has a duplicated address #4824
Conversation
Here is the report for 0b11bc3 (NyanKiyoshi/saleor @ core/unique-addresses) No differences were found. (click me)
# api.benchmark checkout
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
add billing address to checkout 34 34 20
add shipping to checkout 7 7 0
checkout payment charge 14 14 0
complete checkout 6 6 0
create checkout 48 48 24
# api.benchmark homepage
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
retrieve main menu 5 5 0
retrieve product list 4 4 0
retrieve secondary menu 5 5 0
retrieve shop 2 2 0
# api.benchmark product
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
product details 15 15 3
retrieve product attributes 13 13 2
# api.benchmark variant
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
retrieve variant list 18 18 8
# api product sorting attributes
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
sort product not having attribute data 21 21 0 |
Codecov Report
@@ Coverage Diff @@
## master #4824 +/- ##
=======================================
Coverage 91.26% 91.26%
=======================================
Files 344 344
Lines 20617 20617
Branches 1956 1956
=======================================
Hits 18817 18817
Misses 1263 1263
Partials 537 537 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #4824 +/- ##
==========================================
+ Coverage 91.25% 91.26% +0.01%
==========================================
Files 344 344
Lines 20623 20617 -6
Branches 1956 1956
==========================================
- Hits 18819 18817 -2
+ Misses 1266 1263 -3
+ Partials 538 537 -1
Continue to review full report at Codecov.
|
Closes #4592
Pull Request Checklist