Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fetching staff user without manage_users permission #4835

Merged

Conversation

fowczarek
Copy link
Member

@fowczarek fowczarek commented Oct 10, 2019

I want to merge this change because resolve #4831

Screenshots

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. GraphQL schema and type definitions are up to date.
  8. Changes are mentioned in the changelog.

@fowczarek fowczarek added the graphql Issues related to the GraphQL API label Oct 10, 2019
@fowczarek fowczarek self-assigned this Oct 10, 2019
Copy link

django-queries commented Oct 10, 2019

Here is the report for 4897c10 (mirumee/saleor @ 4831/fetch_staff_user_without_manage_users_permission)
Base comparison is a4cf758.

No differences were found. (click me)

# api.benchmark checkout
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  add billing address to checkout            	         34	         34	             20
  add shipping to checkout                   	          7	          7	              0
  checkout payment charge                    	         14	         14	              0
  complete checkout                          	          6	          6	              0
  create checkout                            	         48	         48	             24

# api.benchmark homepage
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  retrieve main menu                         	          5	          5	              0
  retrieve product list                      	          4	          4	              0
  retrieve secondary menu                    	          5	          5	              0
  retrieve shop                              	          2	          2	              0

# api.benchmark product
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  product details                            	         15	         15	              3
  retrieve product attributes                	         13	         13	              2

# api.benchmark variant
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  retrieve variant list                      	         15	         15	              6

# api product sorting attributes
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  sort product not having attribute data     	         21	         21	              0

@codecov
Copy link

codecov bot commented Oct 10, 2019

Codecov Report

Merging #4835 into master will decrease coverage by <.01%.
The diff coverage is 87.8%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4835      +/-   ##
==========================================
- Coverage   91.25%   91.24%   -0.01%     
==========================================
  Files         344      344              
  Lines       20630    20653      +23     
  Branches     1958     1964       +6     
==========================================
+ Hits        18825    18845      +20     
  Misses       1266     1266              
- Partials      539      542       +3
Impacted Files Coverage Δ
saleor/graphql/decorators.py 100% <100%> (ø) ⬆️
saleor/graphql/account/schema.py 100% <100%> (ø) ⬆️
saleor/graphql/account/types.py 96.5% <100%> (ø) ⬆️
saleor/graphql/account/resolvers.py 90.19% <66.66%> (-9.81%) ⬇️
saleor/account/models.py 91.61% <0%> (+1.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4cf758...4897c10. Read the comment docs.

saleor/graphql/account/schema.py Show resolved Hide resolved
saleor/graphql/account/resolvers.py Outdated Show resolved Hide resolved
saleor/graphql/decorators.py Outdated Show resolved Hide resolved
saleor/graphql/decorators.py Outdated Show resolved Hide resolved
saleor/graphql/decorators.py Outdated Show resolved Hide resolved
saleor/graphql/decorators.py Outdated Show resolved Hide resolved
tests/api/test_account.py Outdated Show resolved Hide resolved
saleor/graphql/account/resolvers.py Outdated Show resolved Hide resolved
saleor/graphql/account/resolvers.py Outdated Show resolved Hide resolved
@fowczarek fowczarek force-pushed the 4831/fetch_staff_user_without_manage_users_permission branch from dd73e4f to 4897c10 Compare October 11, 2019 09:04
@maarcingebala maarcingebala merged commit d3c8757 into master Oct 11, 2019
@maarcingebala maarcingebala deleted the 4831/fetch_staff_user_without_manage_users_permission branch October 11, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graphql Issues related to the GraphQL API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't fetch staff user without manage_users permission
4 participants