Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validate for query param should be a valid string #4822 #4836

Merged

Conversation

nix010
Copy link
Contributor

@nix010 nix010 commented Oct 10, 2019

I want to merge this change because resolve #4822

Screenshots

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. GraphQL schema and type definitions are up to date.
  8. Changes are mentioned in the changelog.

Copy link

django-queries commented Oct 10, 2019

Here is the report for ad69dfd (nix010/saleor @ feature/validate-query-param-string)
Base comparison is b92e705.

No differences were found. (click me)

# api.benchmark checkout
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  add billing address to checkout            	         34	         34	             20
  add shipping to checkout                   	          7	          7	              0
  checkout payment charge                    	         14	         14	              0
  complete checkout                          	          6	          6	              0
  create checkout                            	         48	         48	             24

# api.benchmark homepage
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  retrieve main menu                         	          5	          5	              0
  retrieve product list                      	          4	          4	              0
  retrieve secondary menu                    	          5	          5	              0
  retrieve shop                              	          2	          2	              0

# api.benchmark product
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  product details                            	         15	         15	              3
  retrieve product attributes                	         13	         13	              2

# api.benchmark variant
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  retrieve variant list                      	         15	         15	              6

# api product sorting attributes
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  sort product not having attribute data     	         21	         21	              0

@codecov
Copy link

codecov bot commented Oct 10, 2019

Codecov Report

Merging #4836 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4836      +/-   ##
==========================================
- Coverage   91.25%   91.25%   -0.01%     
==========================================
  Files         344      344              
  Lines       20623    20630       +7     
  Branches     1956     1958       +2     
==========================================
+ Hits        18819    18825       +6     
  Misses       1266     1266              
- Partials      538      539       +1
Impacted Files Coverage Δ
saleor/graphql/views.py 82.84% <100%> (ø) ⬆️
saleor/graphql/webhook/mutations.py 91.83% <0%> (-0.56%) ⬇️
saleor/graphql/webhook/types.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b92e705...ad69dfd. Read the comment docs.

@maarcingebala
Copy link
Member

@nix010 could you also add entry about this change to the "Unreleased" section in the CHANGELOG.md file?

@nix010
Copy link
Contributor Author

nix010 commented Oct 11, 2019

@maarcingebala yes. just added

@maarcingebala maarcingebala merged commit 658caab into saleor:master Oct 11, 2019
@maarcingebala
Copy link
Member

Thanks for your PR and for taking part in Hacktoberfest! Send me your shipping address and preferred socks size (40-43 or 44-46) to marcin@mirumee.com and we'll send you a gift! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check whether the GraphQL query is a string before executing
4 participants