-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validate for query param should be a valid string #4822 #4836
Add validate for query param should be a valid string #4822 #4836
Conversation
Here is the report for ad69dfd (nix010/saleor @ feature/validate-query-param-string) No differences were found. (click me)
# api.benchmark checkout
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
add billing address to checkout 34 34 20
add shipping to checkout 7 7 0
checkout payment charge 14 14 0
complete checkout 6 6 0
create checkout 48 48 24
# api.benchmark homepage
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
retrieve main menu 5 5 0
retrieve product list 4 4 0
retrieve secondary menu 5 5 0
retrieve shop 2 2 0
# api.benchmark product
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
product details 15 15 3
retrieve product attributes 13 13 2
# api.benchmark variant
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
retrieve variant list 15 15 6
# api product sorting attributes
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
sort product not having attribute data 21 21 0 |
Codecov Report
@@ Coverage Diff @@
## master #4836 +/- ##
==========================================
- Coverage 91.25% 91.25% -0.01%
==========================================
Files 344 344
Lines 20623 20630 +7
Branches 1956 1958 +2
==========================================
+ Hits 18819 18825 +6
Misses 1266 1266
- Partials 538 539 +1
Continue to review full report at Codecov.
|
@nix010 could you also add entry about this change to the "Unreleased" section in the |
@maarcingebala yes. just added |
Thanks for your PR and for taking part in Hacktoberfest! Send me your shipping address and preferred socks size (40-43 or 44-46) to |
I want to merge this change because resolve #4822
Screenshots
Pull Request Checklist