Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with free shipping voucher #4942

Merged
merged 3 commits into from
Nov 6, 2019

Conversation

IKarbowiak
Copy link
Member

@IKarbowiak IKarbowiak commented Nov 6, 2019

Fix problem with free shipping method - now free shipping voucher slash off the shipment price instead of the lower amount

Fixes #4925

Screenshots

Before:
image

After:
image

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. GraphQL schema and type definitions are up to date.
  8. Changes are mentioned in the changelog.

@IKarbowiak IKarbowiak added the bug label Nov 6, 2019
@IKarbowiak IKarbowiak self-assigned this Nov 6, 2019
Copy link

django-queries commented Nov 6, 2019

Here is the report for 2437941 (mirumee/saleor @ fix-free-shipping-voucher)
Base comparison is 05af589.

No differences were found. (click me)

# api.benchmark checkout
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  add billing address to checkout            	         34	         34	             20
  add shipping to checkout                   	          7	          7	              0
  checkout payment charge                    	         14	         14	              0
  complete checkout                          	          6	          6	              0
  create checkout                            	         48	         48	             24

# api.benchmark homepage
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  retrieve main menu                         	          5	          5	              0
  retrieve product list                      	          4	          4	              0
  retrieve secondary menu                    	          5	          5	              0
  retrieve shop                              	          2	          2	              0

# api.benchmark product
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  product details                            	         15	         15	              3
  retrieve product attributes                	         13	         13	              2

# api.benchmark variant
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  product variant bulk create                	         51	         51	              3
  retrieve variant list                      	         15	         15	              6

# api product sorting attributes
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  sort product not having attribute data     	         21	         21	              0

@codecov
Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #4942 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4942      +/-   ##
==========================================
+ Coverage   91.41%   91.42%   +0.01%     
==========================================
  Files         351      351              
  Lines       21183    21183              
  Branches     2032     2032              
==========================================
+ Hits        19364    19367       +3     
+ Misses       1263     1260       -3     
  Partials      556      556
Impacted Files Coverage Δ
saleor/checkout/utils.py 83.99% <100%> (ø) ⬆️
saleor/discount/models.py 91.11% <0%> (+2.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05af589...2437941. Read the comment docs.

@maarcingebala maarcingebala merged commit 50f299d into master Nov 6, 2019
@maarcingebala maarcingebala deleted the fix-free-shipping-voucher branch November 6, 2019 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Free shipping voucher applies to lower amount instead of shipment
4 participants