-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to delete category and leave products #4970
Allow to delete category and leave products #4970
Conversation
…False' as default
…ion for 'is_published' field
…lish products after category delete
…cts after category delete
… update for category model changes
Here is the report for d79112b (mirumee/saleor @ allow-to-delete-category-and-leave-products) No differences were found. (click me)
# api.benchmark checkout
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
add billing address to checkout 34 34 20
add shipping to checkout 7 7 0
checkout payment charge 14 14 0
complete checkout 6 6 0
create checkout 50 50 24
# api.benchmark homepage
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
retrieve main menu 5 5 0
retrieve product list 4 4 0
retrieve secondary menu 5 5 0
retrieve shop 2 2 0
# api.benchmark product
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
product details 15 15 3
retrieve product attributes 13 13 2
# api.benchmark variant
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
product variant bulk create 51 51 3
retrieve variant list 15 15 6
# api product sorting attributes
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
sort product not having attribute data 21 21 0 |
Codecov Report
@@ Coverage Diff @@
## master #4970 +/- ##
==========================================
+ Coverage 91.17% 91.18% +0.01%
==========================================
Files 351 351
Lines 21340 21391 +51
Branches 2037 2042 +5
==========================================
+ Hits 19457 19506 +49
- Misses 1328 1329 +1
- Partials 555 556 +1
Continue to review full report at Codecov.
|
…typo in dashboard validation
…shboard validation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Allow to create product without category. After removing category, related products become unpublished and minimal variant price is recalculated.
Closes #1928
Pull Request Checklist