-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow staff member to receive notification about customers orders #4993
Allow staff member to receive notification about customers orders #4993
Conversation
644dbc4
to
90feccc
Compare
6cba3be
to
78e76a6
Compare
78e76a6
to
dc0c0f8
Compare
af9fb24
to
24ba03b
Compare
2dc85fb
to
0a768eb
Compare
Maybe some tests for |
i'm working on some tests :P |
0a768eb
to
41d4cc3
Compare
Codecov Report
@@ Coverage Diff @@
## master #4993 +/- ##
==========================================
+ Coverage 90.85% 90.89% +0.03%
==========================================
Files 294 294
Lines 18170 18269 +99
Branches 1671 1679 +8
==========================================
+ Hits 16508 16605 +97
- Misses 1227 1228 +1
- Partials 435 436 +1
Continue to review full report at Codecov.
|
Here is the report for 348dff0 (kswiatek92/saleor @ receive-notification-about-customers-order) No differences were found. (click me)
# api.benchmark checkout
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
add billing address to checkout 34 34 20
add shipping to checkout 7 7 0
checkout payment charge 10 10 0
complete checkout 8 8 0
create checkout 50 50 24
# api.benchmark homepage
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
retrieve main menu 5 5 0
retrieve product list 4 4 0
retrieve secondary menu 5 5 0
retrieve shop 2 2 0
# api.benchmark product
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
product details 15 15 3
retrieve product attributes 9 9 0
# api.benchmark variant
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
product variant bulk create 51 51 3
retrieve variant list 15 15 6
# api product sorting attributes
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
sort product not having attribute data 21 21 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
41d4cc3
to
198ba16
Compare
198ba16
to
1900ad5
Compare
8ca52b0
to
7ba8f8d
Compare
6c18bd6
to
c1b7243
Compare
1fbb45d
to
207cb02
Compare
207cb02
to
891b03b
Compare
Requested changes were made.
closes #4932
Pull Request Checklist