-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize the queries for product list in the dashboard #4995
Conversation
24893ff
to
708d49c
Compare
708d49c
to
d98bb13
Compare
Codecov Report
@@ Coverage Diff @@
## master #4995 +/- ##
==========================================
+ Coverage 91.19% 91.19% +<.01%
==========================================
Files 351 351
Lines 21399 21403 +4
Branches 2042 2044 +2
==========================================
+ Hits 19514 19518 +4
Misses 1329 1329
Partials 556 556
Continue to review full report at Codecov.
|
Here is the report for 9d59db9 (mirumee/saleor @ optimize-queries-for-product-list) **Found 1 differences!** (click me)
# api.benchmark checkout
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
add billing address to checkout 34 34 20
add shipping to checkout 7 7 0
checkout payment charge 14 14 0
complete checkout 8 8 0
create checkout 50 50 24
# api.benchmark homepage
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
retrieve main menu 5 5 0
retrieve product list 4 4 0
retrieve secondary menu 5 5 0
retrieve shop 2 2 0
# api.benchmark product
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
product details 15 15 3
+ retrieve product attributes 13 9 0
# api.benchmark variant
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
product variant bulk create 51 51 3
retrieve variant list 15 15 6
# api product sorting attributes
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
sort product not having attribute data 21 21 0 |
Reduce number of queries for product list to 66.
Closes #4793
Pull Request Checklist