Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed JSON encoding error on Google Analytics reporting #5004

Merged
merged 1 commit into from
Nov 25, 2019

Conversation

NyanKiyoshi
Copy link
Member

Closes #4050

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. GraphQL schema and type definitions are up to date.
  8. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Nov 25, 2019

Codecov Report

Merging #5004 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5004      +/-   ##
==========================================
+ Coverage    91.2%   91.21%   +0.01%     
==========================================
  Files         351      351              
  Lines       21403    21404       +1     
  Branches     2044     2044              
==========================================
+ Hits        19520    19524       +4     
+ Misses       1328     1326       -2     
+ Partials      555      554       -1
Impacted Files Coverage Δ
saleor/core/analytics.py 94.28% <100%> (+8.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3a5d79...8301dde. Read the comment docs.

Copy link

django-queries commented Nov 25, 2019

Here is the report for 8301dde (NyanKiyoshi/saleor @ fix/google-analytics)
Base comparison is c3a5d79.

No differences were found. (click me)

# api.benchmark checkout
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  add billing address to checkout            	         34	         34	             20
  add shipping to checkout                   	          7	          7	              0
  checkout payment charge                    	         10	         10	              0
  complete checkout                          	          8	          8	              0
  create checkout                            	         50	         50	             24

# api.benchmark homepage
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  retrieve main menu                         	          5	          5	              0
  retrieve product list                      	          4	          4	              0
  retrieve secondary menu                    	          5	          5	              0
  retrieve shop                              	          2	          2	              0

# api.benchmark product
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  product details                            	         15	         15	              3
  retrieve product attributes                	          9	          9	              0

# api.benchmark variant
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  product variant bulk create                	         51	         51	              3
  retrieve variant list                      	         15	         15	              6

# api product sorting attributes
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  sort product not having attribute data     	         21	         21	              0

@maarcingebala
Copy link
Member

@NyanKiyoshi Black failed on Travis, can you fix the formatting?

@NyanKiyoshi
Copy link
Member Author

Done, thanks! Looks like isort messed up with the black formatting 😉 (I run them manually)

@maarcingebala maarcingebala merged commit 67cce44 into saleor:master Nov 25, 2019
@NyanKiyoshi NyanKiyoshi deleted the fix/google-analytics branch November 25, 2019 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

json serialization error with google analytics enabled
3 participants