-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed JSON encoding error on Google Analytics reporting #5004
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5004 +/- ##
==========================================
+ Coverage 91.2% 91.21% +0.01%
==========================================
Files 351 351
Lines 21403 21404 +1
Branches 2044 2044
==========================================
+ Hits 19520 19524 +4
+ Misses 1328 1326 -2
+ Partials 555 554 -1
Continue to review full report at Codecov.
|
Here is the report for 8301dde (NyanKiyoshi/saleor @ fix/google-analytics) No differences were found. (click me)
# api.benchmark checkout
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
add billing address to checkout 34 34 20
add shipping to checkout 7 7 0
checkout payment charge 10 10 0
complete checkout 8 8 0
create checkout 50 50 24
# api.benchmark homepage
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
retrieve main menu 5 5 0
retrieve product list 4 4 0
retrieve secondary menu 5 5 0
retrieve shop 2 2 0
# api.benchmark product
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
product details 15 15 3
retrieve product attributes 9 9 0
# api.benchmark variant
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
product variant bulk create 51 51 3
retrieve variant list 15 15 6
# api product sorting attributes
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
sort product not having attribute data 21 21 0 |
c1f5e9e
to
28d32a5
Compare
@NyanKiyoshi Black failed on Travis, can you fix the formatting? |
28d32a5
to
3c4cf05
Compare
Done, thanks! Looks like isort messed up with the black formatting 😉 (I run them manually) |
3c4cf05
to
8301dde
Compare
Closes #4050
Pull Request Checklist