Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor translation queries #5007

Merged
merged 7 commits into from
Nov 27, 2019
Merged

Conversation

fowczarek
Copy link
Member

@fowczarek fowczarek commented Nov 25, 2019

I want to merge this change because resolve #4957

Screenshots

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. GraphQL schema and type definitions are up to date.
  8. Changes are mentioned in the changelog.

@fowczarek fowczarek self-assigned this Nov 25, 2019
@fowczarek fowczarek added in progress graphql Issues related to the GraphQL API labels Nov 25, 2019
Copy link

django-queries commented Nov 25, 2019

Here is the report for bd380a0 (mirumee/saleor @ 4957/refacotr_translations_query)
Base comparison is 67cce44.

No differences were found. (click me)

# api.benchmark checkout
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  add billing address to checkout            	         34	         34	             20
  add shipping to checkout                   	          7	          7	              0
  checkout payment charge                    	         10	         10	              0
  complete checkout                          	          8	          8	              0
  create checkout                            	         50	         50	             24

# api.benchmark homepage
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  retrieve main menu                         	          5	          5	              0
  retrieve product list                      	          4	          4	              0
  retrieve secondary menu                    	          5	          5	              0
  retrieve shop                              	          2	          2	              0

# api.benchmark product
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  product details                            	         15	         15	              3
  retrieve product attributes                	          9	          9	              0

# api.benchmark variant
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  product variant bulk create                	         51	         51	              3
  retrieve variant list                      	         15	         15	              6

# api product sorting attributes
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  sort product not having attribute data     	         21	         21	              0

@codecov
Copy link

codecov bot commented Nov 25, 2019

Codecov Report

Merging #5007 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5007      +/-   ##
==========================================
- Coverage   91.21%   91.21%   -0.01%     
==========================================
  Files         351      353       +2     
  Lines       21404    21399       -5     
  Branches     2044     2044              
==========================================
- Hits        19524    19519       -5     
  Misses       1326     1326              
  Partials      554      554
Impacted Files Coverage Δ
saleor/graphql/translations/schema.py 98.46% <ø> (-0.17%) ⬇️
saleor/graphql/shop/types.py 96.17% <100%> (+0.02%) ⬆️
saleor/graphql/page/types.py 100% <100%> (ø) ⬆️
saleor/graphql/menu/types.py 100% <100%> (ø) ⬆️
saleor/graphql/translations/fields.py 100% <100%> (ø)
saleor/graphql/api.py 100% <100%> (ø) ⬆️
saleor/graphql/shipping/types.py 100% <100%> (ø) ⬆️
saleor/graphql/product/types/products.py 91.18% <100%> (-0.03%) ⬇️
saleor/graphql/translations/descriptions.py 100% <100%> (ø)
saleor/graphql/translations/types.py 98.5% <100%> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67cce44...bd380a0. Read the comment docs.

saleor/graphql/translations/descriptions.py Outdated Show resolved Hide resolved
saleor/graphql/discount/types.py Outdated Show resolved Hide resolved
@NyanKiyoshi NyanKiyoshi changed the title Refactor translatnions query Refactor translation queries Nov 25, 2019
Copy link
Member

@maarcingebala maarcingebala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@maarcingebala maarcingebala merged commit e31d7bf into master Nov 27, 2019
@maarcingebala maarcingebala deleted the 4957/refacotr_translations_query branch November 27, 2019 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graphql Issues related to the GraphQL API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor translatnions query
4 participants