Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order status after order update #5072

Merged
merged 3 commits into from
Dec 16, 2019

Conversation

fowczarek
Copy link
Member

I want to merge this change because resolve #4978

Screenshots

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. GraphQL schema and type definitions are up to date.
  8. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Dec 16, 2019

Codecov Report

Merging #5072 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5072      +/-   ##
==========================================
+ Coverage   90.92%   90.93%   +<.01%     
==========================================
  Files         294      294              
  Lines       18277    18286       +9     
  Branches     1682     1684       +2     
==========================================
+ Hits        16619    16628       +9     
  Misses       1224     1224              
  Partials      434      434
Impacted Files Coverage Δ
saleor/graphql/order/mutations/orders.py 96.45% <100%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9879a18...f99d2d4. Read the comment docs.

Copy link

django-queries commented Dec 16, 2019

Here is the report for f99d2d4 (mirumee/saleor @ 4978/draft_status_after_order_update)
Base comparison is 9879a18.

No differences were found. (click me)

# api.benchmark checkout
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  add billing address to checkout            	         34	         34	             20
  add shipping to checkout                   	          7	          7	              0
  checkout payment charge                    	         10	         10	              0
  complete checkout                          	          8	          8	              0
  create checkout                            	         50	         50	             24

# api.benchmark homepage
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  retrieve main menu                         	          5	          5	              0
  retrieve product list                      	          4	          4	              0
  retrieve secondary menu                    	          5	          5	              0
  retrieve shop                              	          2	          2	              0

# api.benchmark product
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  product details                            	         15	         15	              3
  retrieve product attributes                	          9	          9	              0

# api.benchmark variant
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  product variant bulk create                	         51	         51	              3
  retrieve variant list                      	         15	         15	              6

# api product sorting attributes
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  sort product not having attribute data     	         21	         21	              0

@fowczarek fowczarek self-assigned this Dec 16, 2019
@fowczarek fowczarek added the graphql Issues related to the GraphQL API label Dec 16, 2019
@maarcingebala maarcingebala merged commit 1149a8c into master Dec 16, 2019
@maarcingebala maarcingebala deleted the 4978/draft_status_after_order_update branch December 16, 2019 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graphql Issues related to the GraphQL API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editing order change it's status to DRAFT
4 participants