Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gateways forms and templates #5075

Merged
merged 6 commits into from
Dec 18, 2019

Conversation

IKarbowiak
Copy link
Member

@IKarbowiak IKarbowiak commented Dec 17, 2019

Remove forms and templates from gateways.
Resolves #5030

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. GraphQL schema and type definitions are up to date.
  8. Changes are mentioned in the changelog.

@IKarbowiak IKarbowiak self-assigned this Dec 17, 2019
@codecov
Copy link

codecov bot commented Dec 17, 2019

Codecov Report

Merging #5075 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5075      +/-   ##
==========================================
- Coverage   91.08%   91.05%   -0.03%     
==========================================
  Files         248      245       -3     
  Lines       16392    16291     -101     
  Branches     1498     1494       -4     
==========================================
- Hits        14930    14834      -96     
+ Misses       1070     1066       -4     
+ Partials      392      391       -1
Impacted Files Coverage Δ
saleor/core/payments.py 65.62% <ø> (-0.09%) ⬇️
saleor/payment/gateways/stripe/plugin.py 0% <ø> (ø) ⬆️
saleor/extensions/manager.py 86.15% <ø> (-0.21%) ⬇️
saleor/payment/gateways/braintree/__init__.py 93.57% <ø> (-0.18%) ⬇️
saleor/payment/gateways/dummy/plugin.py 91.66% <ø> (+1.04%) ⬆️
saleor/payment/interface.py 96.87% <ø> (-0.05%) ⬇️
saleor/payment/gateway.py 91.47% <ø> (-0.32%) ⬇️
saleor/payment/gateways/razorpay/__init__.py 98.27% <ø> (-0.09%) ⬇️
saleor/extensions/base_plugin.py 88.88% <ø> (-0.09%) ⬇️
saleor/payment/gateways/braintree/plugin.py 0% <ø> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3ec3cb...a42f780. Read the comment docs.

Copy link

django-queries commented Dec 17, 2019

Here is the report for a42f780 (mirumee/saleor @ remove-gateways-forms-and-templates)
Base comparison is d3ec3cb.

No differences were found. (click me)

# api.benchmark checkout
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  add billing address to checkout            	         34	         34	             20
  add shipping to checkout                   	          7	          7	              0
  checkout payment charge                    	         10	         10	              0
  complete checkout                          	          8	          8	              0
  create checkout                            	         50	         50	             24

# api.benchmark homepage
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  retrieve main menu                         	          5	          5	              0
  retrieve product list                      	          4	          4	              0
  retrieve secondary menu                    	          5	          5	              0
  retrieve shop                              	          2	          2	              0

# api.benchmark product
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  product details                            	         15	         15	              3
  retrieve product attributes                	          9	          9	              0

# api.benchmark variant
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  product variant bulk create                	         51	         51	              3
  retrieve variant list                      	         15	         15	              6

# api product sorting attributes
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  sort product not having attribute data     	         21	         21	              0

@maarcingebala maarcingebala merged commit 3d3b2a7 into master Dec 18, 2019
@maarcingebala maarcingebala deleted the remove-gateways-forms-and-templates branch December 18, 2019 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove forms/templates support from payment gateways
4 participants