Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search by sku in products query #5117

Merged
merged 4 commits into from
Jan 7, 2020
Merged

Search by sku in products query #5117

merged 4 commits into from
Jan 7, 2020

Conversation

fowczarek
Copy link
Member

@fowczarek fowczarek commented Dec 27, 2019

I want to merge this change because resolve #4531

I found the bug and fixed it. Before this PR we weren't able to search on unpublished products.

Screenshots

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. GraphQL schema and type definitions are up to date.
  8. Changes are mentioned in the changelog.

@fowczarek fowczarek self-assigned this Dec 27, 2019
@codecov
Copy link

codecov bot commented Dec 27, 2019

Codecov Report

Merging #5117 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5117   +/-   ##
=======================================
  Coverage   91.13%   91.13%           
=======================================
  Files         261      261           
  Lines       16855    16855           
  Branches     1501     1501           
=======================================
  Hits        15360    15360           
  Misses       1094     1094           
  Partials      401      401

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 633975e...a5850b4. Read the comment docs.

Copy link

django-queries commented Dec 27, 2019

Here is the report for 633975e (mirumee/saleor @ 4531/search_by_sku)
Base comparison is 9502467.

No differences were found. (click me)

# api.benchmark checkout
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  add billing address to checkout            	         34	         34	             20
  add shipping to checkout                   	          7	          7	              0
  checkout payment charge                    	         10	         10	              0
  complete checkout                          	          8	          8	              0
  create checkout                            	         50	         50	             24

# api.benchmark homepage
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  retrieve main menu                         	          5	          5	              0
  retrieve product list                      	          4	          4	              0
  retrieve secondary menu                    	          5	          5	              0
  retrieve shop                              	          2	          2	              0

# api.benchmark product
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  product details                            	         15	         15	              3
  retrieve product attributes                	          9	          9	              0

# api.benchmark variant
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  product variant bulk create                	         51	         51	              3
  retrieve variant list                      	         15	         15	              6

# api product sorting attributes
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  sort product not having attribute data     	         21	         21	              0

@maarcingebala maarcingebala merged commit b38ad82 into master Jan 7, 2020
@maarcingebala maarcingebala deleted the 4531/search_by_sku branch January 7, 2020 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to search for products by SKU in admin dashboard
4 participants