-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mypy checks #5150
Add mypy checks #5150
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5150 +/- ##
========================================
Coverage ? 91.7%
========================================
Files ? 260
Lines ? 16838
Branches ? 1482
========================================
Hits ? 15442
Misses ? 1008
Partials ? 388
Continue to review full report at Codecov.
|
Here is the report for 64541ac (mirumee/saleor @ add-mypy-checks) No differences were found. (click me)
# api.benchmark checkout
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
add billing address to checkout 34 34 20
add shipping to checkout 7 7 0
checkout payment charge 10 10 0
complete checkout 8 8 0
create checkout 50 50 24
# api.benchmark homepage
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
retrieve main menu 5 5 0
retrieve product list 4 4 0
retrieve secondary menu 5 5 0
retrieve shop 2 2 0
# api.benchmark product
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
product details 14 14 2
retrieve product attributes 9 9 0
# api.benchmark variant
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
product variant bulk create 51 51 3
retrieve variant list 16 16 6
# api product sorting attributes
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
sort product not having attribute data 21 21 0 |
e3b4705
to
7964037
Compare
31041b5
to
df0c421
Compare
Some clarification:
|
I guess it's fine to have those |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪 lots of improvements!
Add mypy to CI and pre-commit checks. Fix mypy errors.
Closes #4720
Pull Request Checklist