-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to assign multiple warehouses in mutations to create/update a shipping zone #5399
Merged
maarcingebala
merged 8 commits into
master
from
723/Assign_muliple_warehouse_to_shipping_zone
Mar 30, 2020
Merged
Add ability to assign multiple warehouses in mutations to create/update a shipping zone #5399
maarcingebala
merged 8 commits into
master
from
723/Assign_muliple_warehouse_to_shipping_zone
Mar 30, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5399 +/- ##
==========================================
+ Coverage 91.12% 91.13% +0.01%
==========================================
Files 283 283
Lines 18297 18324 +27
Branches 1601 1607 +6
==========================================
+ Hits 16673 16700 +27
Misses 1195 1195
Partials 429 429
Continue to review full report at Codecov.
|
fowczarek
force-pushed
the
723/Assign_muliple_warehouse_to_shipping_zone
branch
from
March 27, 2020 11:46
34e762f
to
25ef19a
Compare
fowczarek
requested review from
maarcingebala,
IKarbowiak and
tomaszszymanski129
March 30, 2020 08:13
IKarbowiak
approved these changes
Mar 30, 2020
maarcingebala
approved these changes
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to merge this change because adding the ability to assign multiple warehouses in mutations to create/update a shipping zone.
In
shippingZoneCreate
mutation I add the field with warehouses to add to a shipping zone.In
shippingZoneUpdate
mutation I add fields with warehouses to add and remove from a shipping zone.Impact
Pull Request Checklist