Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to assign multiple warehouses in mutations to create/update a shipping zone #5399

Merged
merged 8 commits into from
Mar 30, 2020

Conversation

fowczarek
Copy link
Member

@fowczarek fowczarek commented Mar 27, 2020

I want to merge this change because adding the ability to assign multiple warehouses in mutations to create/update a shipping zone.

In shippingZoneCreate mutation I add the field with warehouses to add to a shipping zone.
In shippingZoneUpdate mutation I add fields with warehouses to add and remove from a shipping zone.

Impact

  • New migrations
  • New/Updated API fields or mutations
  • Deprecated API fields or mutations
  • Removed API types, fields, or mutations

Pull Request Checklist

  • Privileged queries and mutations are guarded by proper permission checks
  • Database queries are optimized and the number of queries is constant
  • Database migration files are up to date
  • The changes are tested
  • GraphQL schema and type definitions are up to date
  • Changes are mentioned in the changelog

@fowczarek fowczarek self-assigned this Mar 27, 2020
@codecov
Copy link

codecov bot commented Mar 27, 2020

Codecov Report

Merging #5399 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5399      +/-   ##
==========================================
+ Coverage   91.12%   91.13%   +0.01%     
==========================================
  Files         283      283              
  Lines       18297    18324      +27     
  Branches     1601     1607       +6     
==========================================
+ Hits        16673    16700      +27     
  Misses       1195     1195              
  Partials      429      429              
Impacted Files Coverage Δ
saleor/graphql/core/types/common.py 100.00% <100.00%> (ø)
saleor/graphql/core/utils/__init__.py 100.00% <100.00%> (ø)
saleor/graphql/shipping/mutations.py 97.53% <100.00%> (+0.42%) ⬆️
saleor/graphql/shipping/types.py 100.00% <100.00%> (ø)
saleor/shipping/error_codes.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 880e053...52c5bb6. Read the comment docs.

@fowczarek fowczarek force-pushed the 723/Assign_muliple_warehouse_to_shipping_zone branch from 34e762f to 25ef19a Compare March 27, 2020 11:46
saleor/graphql/shipping/mutations.py Outdated Show resolved Hide resolved
saleor/graphql/shipping/mutations.py Outdated Show resolved Hide resolved
saleor/graphql/shipping/mutations.py Outdated Show resolved Hide resolved
saleor/graphql/shipping/mutations.py Outdated Show resolved Hide resolved
saleor/graphql/core/mutations.py Outdated Show resolved Hide resolved
@maarcingebala maarcingebala merged commit e5436bd into master Mar 30, 2020
@maarcingebala maarcingebala deleted the 723/Assign_muliple_warehouse_to_shipping_zone branch March 30, 2020 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants