Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shipping rate price validation #5411

Merged
merged 3 commits into from
Apr 2, 2020

Conversation

kswiatek92
Copy link

@kswiatek92 kswiatek92 commented Mar 30, 2020

closes #5361

Pull Request Checklist

  • Privileged queries and mutations are guarded by proper permission checks
  • Database queries are optimized and the number of queries is constant
  • Database migration files are up to date
  • The changes are tested
  • GraphQL schema and type definitions are up to date
  • Changes are mentioned in the changelog

@codecov
Copy link

codecov bot commented Mar 31, 2020

Codecov Report

Merging #5411 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5411      +/-   ##
==========================================
- Coverage   91.13%   91.11%   -0.02%     
==========================================
  Files         283      283              
  Lines       18327    18333       +6     
  Branches     1607     1609       +2     
==========================================
+ Hits        16702    16704       +2     
- Misses       1196     1200       +4     
  Partials      429      429
Impacted Files Coverage Δ
saleor/graphql/shipping/mutations.py 97.56% <100%> (+0.03%) ⬆️
saleor/core/utils/draftjs.py 20% <0%> (-10%) ⬇️
saleor/product/models.py 91.11% <0%> (-0.4%) ⬇️
saleor/demo/settings.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b5d902...9f86781. Read the comment docs.

@maarcingebala maarcingebala merged commit f9b47db into saleor:master Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It should not be possible to have negative price on shipping rate
2 participants