Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attribute validation to attributeAssign #5423

Merged
merged 7 commits into from
Apr 6, 2020

Conversation

kswiatek92
Copy link

closes #5140

Impact

  • New migrations
  • New/Updated API fields or mutations
  • Deprecated API fields or mutations
  • Removed API types, fields, or mutations

Pull Request Checklist

  • Privileged queries and mutations are guarded by proper permission checks
  • Database queries are optimized and the number of queries is constant
  • Database migration files are up to date
  • The changes are tested
  • GraphQL schema and type definitions are up to date
  • Changes are mentioned in the changelog

@codecov
Copy link

codecov bot commented Apr 2, 2020

Codecov Report

Merging #5423 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5423   +/-   ##
=======================================
  Coverage   91.14%   91.14%           
=======================================
  Files         283      283           
  Lines       18341    18358   +17     
  Branches     1613     1617    +4     
=======================================
+ Hits        16716    16733   +17     
  Misses       1196     1196           
  Partials      429      429           
Impacted Files Coverage Δ
saleor/graphql/product/resolvers.py 83.33% <ø> (ø)
saleor/graphql/core/types/common.py 100.00% <100.00%> (ø)
saleor/graphql/product/mutations/attributes.py 98.11% <100.00%> (+0.05%) ⬆️
saleor/graphql/account/mutations/base.py 98.77% <0.00%> (+0.01%) ⬆️
saleor/graphql/account/mutations/account.py 98.48% <0.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1a2831...b8b22f6. Read the comment docs.

@kswiatek92 kswiatek92 force-pushed the validate-attributes branch 2 times, most recently from 03e814f to f640eaf Compare April 2, 2020 09:09
@maarcingebala
Copy link
Member

@IKarbowiak Can you please re-review this one?

@maarcingebala maarcingebala merged commit 0460102 into saleor:master Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assigning a non-existing attribute to a product type crashes
3 participants