-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add information to errors in OrderFulfill mutation #5553
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5553 +/- ##
==========================================
+ Coverage 91.62% 91.64% +0.02%
==========================================
Files 303 303
Lines 19733 19747 +14
Branches 1837 1835 -2
==========================================
+ Hits 18080 18098 +18
+ Misses 1213 1211 -2
+ Partials 440 438 -2
Continue to review full report at Codecov.
|
Here is the report for 82a48c6 (mirumee/saleor @ fix-errors-in-order-fulfill-mutation) No differences were found. (click me)
# api.benchmark account
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
delete staff members 32 32 0
query staff user 21 21 4
staff create 24 24 5
staff update groups and permissions 36 36 6
# api.benchmark category
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
category view 18 18 1
# api.benchmark checkout mutations
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
add billing address to checkout 52 52 26
add shipping to checkout 40 40 12
checkout email update 29 29 13
checkout payment charge 23 23 5
checkout shipping address update 35 35 8
checkout voucher code 59 59 31
complete checkout 74 74 19
create checkout 140 140 75
update checkout lines 101 101 50
# api.benchmark collection
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
collection view 17 17 0
# api.benchmark homepage
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
featured products list 14 14 0
retrieve main menu 8 8 0
retrieve product list 5 5 0
retrieve secondary menu 8 8 0
retrieve shop 2 2 0
user checkout details 52 52 26
# api.benchmark order
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
user order details 17 17 2
# api.benchmark permission group
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
permission group create 21 21 3
permission group delete 21 21 4
permission group query 8 8 0
permission group update 35 35 5
permission group update remove users with manage staff 31 31 4
# api.benchmark product
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
product details 19 19 2
retrieve product attributes 7 7 0
# api.benchmark variant
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
product variant bulk create 48 48 2
retrieve variant list 23 23 6
# api.benchmark variant stocks
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
product variants stocks create 23 23 5
product variants stocks delete 20 20 5
product variants stocks update 28 28 5
# api product sorting attributes
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
sort product not having attribute data 20 20 0 |
I want to merge this change because we should have more information about errors in OrderFulfill mutation.
Impact
Pull Request Checklist