Add configuration field to enable the native 3d secure support #6298

korycins · 2020-10-21T07:31:53Z

Add configuration field to enable the native 3d secure
Append 3d secure data to adyen api calls

codecov · 2020-10-21T08:46:10Z

Codecov Report

Merging #6298 into master will decrease coverage by 0.00%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master    #6298      +/-   ##
==========================================
- Coverage   91.83%   91.82%   -0.01%     
==========================================
  Files         391      391              
  Lines       25967    26024      +57     
  Branches     2451     2463      +12     
==========================================
+ Hits        23847    23897      +50     
- Misses       1527     1532       +5     
- Partials      593      595       +2

Impacted Files	Coverage Δ
saleor/payment/gateways/adyen/plugin.py	`76.50% <0.00%> (-0.94%)`	⬇️
saleor/payment/gateways/adyen/webhooks.py	`80.49% <25.00%> (-0.62%)`	⬇️
saleor/payment/gateway.py	`92.94% <60.00%> (-1.14%)`	⬇️
saleor/payment/gateways/adyen/utils.py	`93.98% <100.00%> (+0.23%)`	⬆️
saleor/graphql/page/types.py	`92.30% <0.00%> (-7.70%)`	⬇️
saleor/graphql/meta/resolvers.py	`91.83% <0.00%> (+3.26%)`	⬆️
saleor/graphql/meta/permissions.py	`96.00% <0.00%> (+7.11%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70d3827...03a0f94. Read the comment docs.

db-queries · 2020-10-21T08:52:46Z

Here is the report for 03a0f94 (mirumee/saleor @ adyen_native_3d_secure)
Base comparison is 5410886.

No differences were found. (click me)

# saleor.graphql.accountbenchmark account
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  delete staff members                                       	         32	         32	              0
  query staff user                                           	         20	         20	              4
  staff create                                               	         22	         22	              4
  staff update groups and permissions                        	         33	         33	              5

# saleor.graphql.accountbenchmark permission group
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  permission group create                                    	         19	         19	              2
  permission group delete                                    	         20	         20	              3
  permission group query                                     	          7	          7	              0
  permission group update                                    	         33	         33	              1
  permission group update remove users with manage staff     	         27	         27	              3

# saleor.graphql.checkoutbenchmark checkout mutations
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  add billing address to checkout                            	         72	         72	             42
  add shipping to checkout                                   	         50	         50	             19
  checkout email update                                      	         41	         41	             21
  checkout payment charge                                    	         38	         38	             10
  checkout shipping address update                           	         58	         58	             19
  checkout voucher code                                      	         85	         85	             53
  complete checkout                                          	        119	        119	             25
  create checkout                                            	        130	        130	             64
  update checkout lines                                      	        114	        114	             54

# saleor.graphql.checkoutbenchmark homepage
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  user checkout details                                      	         51	         51	             27

# saleor.graphql.menubenchmark homepage
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  retrieve main menu                                         	          5	          5	              0
  retrieve secondary menu                                    	          5	          5	              0

# saleor.graphql.orderbenchmark order
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  user order details                                         	         17	         17	              3

# saleor.graphql.productbenchmark category
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  category view                                              	         18	         18	              1

# saleor.graphql.productbenchmark collection
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  collection view                                            	         17	         17	              0

# saleor.graphql.productbenchmark homepage
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  featured products list                                     	         14	         14	              0
  retrieve product list                                      	          5	          5	              0

# saleor.graphql.productbenchmark product
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  product details                                            	         16	         16	              0
  retrieve product attributes                                	          7	          7	              0
  retrive products with product types and attributes         	          5	          5	              0

# saleor.graphql.productbenchmark variant
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  product variant bulk create                                	         48	         48	              2
  retrieve variant list                                      	         18	         18	              2

# saleor.graphql.productbenchmark variant stocks
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  product variants stocks create                             	         22	         22	              5
  product variants stocks delete                             	         19	         19	              5
  product variants stocks update                             	         27	         27	              5

# saleor.graphql.producttest product sorting attributes
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  sort product not having attribute data                     	         20	         20	              0

# saleor.graphql.shopbenchmark homepage
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  retrieve shop                                              	          2	          2	              0

saleor/payment/gateways/adyen/plugin.py

Co-authored-by: Marcin Gębala <5421321+maarcingebala@users.noreply.github.com>

* Add configuration field to enable the native 3d secure support * Fix and add more tests related to adyen request payload * Use correct method for additional_details * Return action data for confirm method * Fix logic related with filling up the payment data fields * Update description of configuration field Co-authored-by: Marcin Gębala <5421321+maarcingebala@users.noreply.github.com> Co-authored-by: Marcin Gębala <5421321+maarcingebala@users.noreply.github.com>

* Add slug field to menu (#6258) * Add slug field to menu * Fix tests * Tests improvements * Improve description for validate_one_of_args_is_in_query * Allow MenuFilter to filter with slugs * Add search by slug to menus query * Add attributes validation while creating/updating a product's variant (#6269) * Add attributes validation while creating/updating a product's variant * Update the CHANGELOG.md * Fix failing test * Add handling of empty attributes list * Add metadata to page model (#6292) * Add configuration field to enable the native 3d secure support (#6298) * Add configuration field to enable the native 3d secure support * Fix and add more tests related to adyen request payload * Use correct method for additional_details * Return action data for confirm method * Fix logic related with filling up the payment data fields * Update description of configuration field Co-authored-by: Marcin Gębala <5421321+maarcingebala@users.noreply.github.com> Co-authored-by: Marcin Gębala <5421321+maarcingebala@users.noreply.github.com> * Fix for unnecesary attributes validation while updating simple product (#6300) * Fix for unnecesary attributes validation while updating simple product * Update CHANGELOG.md * Add deprecation to currencies field on shop query (#6306) * Add deprecation to default currency field on shop query (#6311) * Fix invoice layout (#6305) * Fix invoice layout * Missing trans tag Co-authored-by: Tomasz Szymański <tomasz.szymanski@stxnext.pl> Co-authored-by: Grzegorz Derdak <grzegorz.derdak@stxnext.pl> Co-authored-by: Dominik Żegleń <flesz3@o2.pl> Co-authored-by: Maciej Korycinski <korycinski.maciej@gmail.com> Co-authored-by: Filip Owczarek <43955230+fowczarek@users.noreply.github.com>

Add configuration field to enable the native 3d secure support

d573040

korycins self-assigned this Oct 21, 2020

korycins added the test deployment Deploy test environment for pull request label Oct 21, 2020

github-actions bot temporarily deployed to adyen-native-3d-secure October 21, 2020 07:32 Inactive

Fix and add more tests related to adyen request payload

bb96b36

github-actions bot temporarily deployed to adyen-native-3d-secure October 21, 2020 08:36 Inactive

Use correct method for additional_details

426ddac

github-actions bot temporarily deployed to adyen-native-3d-secure October 21, 2020 09:40 Inactive

Return action data for confirm method

ad761a9

github-actions bot temporarily deployed to adyen-native-3d-secure October 21, 2020 10:16 Inactive

Fix logic related with filling up the payment data fields

177da70

github-actions bot temporarily deployed to adyen-native-3d-secure October 21, 2020 14:59 Inactive

maarcingebala reviewed Oct 22, 2020

View reviewed changes

saleor/payment/gateways/adyen/plugin.py Outdated Show resolved Hide resolved

maarcingebala approved these changes Oct 22, 2020

View reviewed changes

maarcingebala requested a review from a team October 22, 2020 07:53

IKarbowiak approved these changes Oct 22, 2020

View reviewed changes

Update description of configuration field

03a0f94

Co-authored-by: Marcin Gębala <5421321+maarcingebala@users.noreply.github.com>

github-actions bot temporarily deployed to adyen-native-3d-secure October 22, 2020 08:23 Inactive

maarcingebala merged commit 90b2887 into master Oct 22, 2020

maarcingebala deleted the adyen_native_3d_secure branch October 22, 2020 08:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add configuration field to enable the native 3d secure support #6298

Add configuration field to enable the native 3d secure support #6298

korycins commented Oct 21, 2020

codecov bot commented Oct 21, 2020 •

edited

db-queries bot commented Oct 21, 2020 •

edited

Add configuration field to enable the native 3d secure support #6298

Add configuration field to enable the native 3d secure support #6298

Conversation

korycins commented Oct 21, 2020

codecov bot commented Oct 21, 2020 • edited

Codecov Report

db-queries bot commented Oct 21, 2020 • edited

codecov bot commented Oct 21, 2020 •

edited

db-queries bot commented Oct 21, 2020 •

edited