Improve aproval rate for adyen requests #6315

korycins · 2020-10-23T11:35:54Z

add shipping as an item to klarna requests
add posibility to include more fields to adyen requests

codecov · 2020-10-23T11:44:06Z

Codecov Report

Merging #6315 into master will increase coverage by 0.01%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master    #6315      +/-   ##
==========================================
+ Coverage   91.88%   91.90%   +0.01%     
==========================================
  Files         391      391              
  Lines       26042    26065      +23     
  Branches     2466     2470       +4     
==========================================
+ Hits        23928    23954      +26     
+ Misses       1528     1519       -9     
- Partials      586      592       +6

Impacted Files	Coverage Δ
saleor/payment/gateways/adyen/utils.py	`90.50% <80.00%> (-3.57%)`	⬇️
saleor/order/utils.py	`90.29% <0.00%> (+0.48%)`	⬆️
saleor/payment/gateways/adyen/plugin.py	`81.97% <0.00%> (+5.23%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f616c7d...788ed68. Read the comment docs.

db-queries · 2020-10-23T11:44:12Z

Here is the report for 788ed68 (mirumee/saleor @ SALEOR-1454-improve-aproval-rate-for-adyen)
Base comparison is f616c7d.

No differences were found. (click me)

# saleor.graphql.accountbenchmark account
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  delete staff members                                       	         32	         32	              0
  query staff user                                           	         20	         20	              4
  staff create                                               	         22	         22	              4
  staff update groups and permissions                        	         33	         33	              5

# saleor.graphql.accountbenchmark permission group
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  permission group create                                    	         19	         19	              2
  permission group delete                                    	         20	         20	              3
  permission group query                                     	          7	          7	              0
  permission group update                                    	         33	         33	              1
  permission group update remove users with manage staff     	         27	         27	              3

# saleor.graphql.checkoutbenchmark checkout mutations
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  add billing address to checkout                            	         72	         72	             42
  add shipping to checkout                                   	         50	         50	             19
  checkout email update                                      	         41	         41	             21
  checkout payment charge                                    	         38	         38	             10
  checkout shipping address update                           	         58	         58	             18
  checkout voucher code                                      	         85	         85	             53
  complete checkout                                          	        119	        119	             25
  create checkout                                            	        130	        130	             64
  update checkout lines                                      	        114	        114	             54

# saleor.graphql.checkoutbenchmark homepage
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  user checkout details                                      	         51	         51	             27

# saleor.graphql.menubenchmark homepage
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  retrieve main menu                                         	          5	          5	              0
  retrieve secondary menu                                    	          5	          5	              0

# saleor.graphql.orderbenchmark order
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  user order details                                         	         17	         17	              3

# saleor.graphql.productbenchmark category
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  category view                                              	         18	         18	              1

# saleor.graphql.productbenchmark collection
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  collection view                                            	         17	         17	              0

# saleor.graphql.productbenchmark homepage
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  featured products list                                     	         14	         14	              0
  retrieve product list                                      	          5	          5	              0

# saleor.graphql.productbenchmark product
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  product details                                            	         16	         16	              0
  retrieve product attributes                                	          7	          7	              0
  retrive products with product types and attributes         	          5	          5	              0

# saleor.graphql.productbenchmark variant
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  product variant bulk create                                	         48	         48	              2
  retrieve variant list                                      	         18	         18	              2

# saleor.graphql.productbenchmark variant stocks
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  product variants stocks create                             	         22	         22	              5
  product variants stocks delete                             	         19	         19	              5
  product variants stocks update                             	         27	         27	              5

# saleor.graphql.producttest product sorting attributes
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  sort product not having attribute data                     	         20	         20	              0

# saleor.graphql.shopbenchmark homepage
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  retrieve shop                                              	          2	          2	              0

saleor/payment/gateways/adyen/utils.py

* Improve aproval rate for adyen requests * Improve the test coverage * Make sure that gross_net is not 0 * Check if field contians data before we will add them to adyen paylaod

* Bump requirements (#6332) * Fix order_updated not triggering on mutation orderupdate (#6336) * Drop origin from Plugin configuration. Take it from the paymentData (#6341) * Drop origin from configuration. Take it from the paymentData * Handle the case when plugin drops configuration field * Apply changes after review Co-authored-by: Marcin Gębala <5421321+maarcingebala@users.noreply.github.com> Co-authored-by: Marcin Gębala <5421321+maarcingebala@users.noreply.github.com> * Fix uvicorn to use standard dependencies (#6345) * Fix empty name and description in updatePlugin mutation response (#6346) * Fix inccorect name and help text for 3D Secure field (#6350) * Fix adyen notifications handling (#6343) * Fix invalid payment_id in get_payment handling * Add merchant account validation in webhooks * Prevent breaking handle_webhook when request is a GET request * Update saleor/payment/gateways/adyen/webhooks.py Co-authored-by: Marcin Gębala <5421321+maarcingebala@users.noreply.github.com> * Update handle_webhook - add logger warnings * Add adyen webhooks get_payment method tests Co-authored-by: Marcin Gębala <5421321+maarcingebala@users.noreply.github.com> * Add order note that refund has been requested (#6347) * Add order note that refund has been requested * Add 'Adyen' at the begginig of the msg * Fix failing saleor autocapture. Improve the handler for authorization (#6348) * Fix failing saleor autocapture. Improve the webhook hanlder for authorization * Handle cases when payment is already voided and when is still active * Fix failing test after merged branches related to adyen (#6355) * Fix failing test after merged branches related to adyen * Fix assert condition * Improve aproval rate for adyen requests (#6315) * Improve aproval rate for adyen requests * Improve the test coverage * Make sure that gross_net is not 0 * Check if field contians data before we will add them to adyen paylaod * Include line total to webhook payload (#6354) * Include line total to webhook payload * Update changelog * Add validation for order update related mutations (#6324) * Run order_updated on order update, secure order update mutations based on order status * Error message fix on DraftOrderUpdate * OrderUpdate mutation improvements and optimizations * Fix for fulfilling an order when product quantity equals allocated quantity (#6333) * Fix for fulfilling an order when product quantity equals allocated quantity * Add tests, update the CHANGELOG.md, modify schema objects * Style improvements * Add data loader, add permission decorator, style changes * Changes after code review * Change aggregation of stock allocations to single allocation (#6362) * Fix for updating product variant without providing an attributes (#6353) * Fix for the ability to filter products on collection (#6363) * Fix filters on collection * Fix broken tests, update CHANGELOG.md * Handle custom schemes (#6370) * Update translations (#6379) * Bump requirements (#6378) * Fix product related dataloaders to be accessible by app (#6380) Co-authored-by: Tomasz Szymański <tomasz.szymanski@stxnext.pl> Co-authored-by: Maciej Korycinski <korycinski.maciej@gmail.com> Co-authored-by: Iga Karbowiak <40886528+IKarbowiak@users.noreply.github.com> Co-authored-by: Grzegorz Derdak <grzegorz.derdak@stxnext.pl>

Improve aproval rate for adyen requests

6ed8259

korycins requested review from IKarbowiak and a team October 23, 2020 11:35

korycins self-assigned this Oct 23, 2020

korycins added the test deployment Deploy test environment for pull request label Oct 23, 2020

github-actions bot temporarily deployed to saleor-1454-improve-aproval-rate-for-adyen October 23, 2020 11:36 Inactive

korycins removed the test deployment Deploy test environment for pull request label Oct 23, 2020

IKarbowiak approved these changes Oct 23, 2020

View reviewed changes

fowczarek approved these changes Oct 26, 2020

View reviewed changes

korycins added the in progress label Oct 26, 2020

Improve the test coverage

a251879

korycins removed the in progress label Oct 26, 2020

maarcingebala reviewed Oct 26, 2020

View reviewed changes

saleor/payment/gateways/adyen/utils.py Show resolved Hide resolved

Maciej Korycinski added 3 commits October 29, 2020 11:23

Make sure that gross_net is not 0

9ef075b

Merge branch 'master' into SALEOR-1454-improve-aproval-rate-for-adyen

7d3e77c

Check if field contians data before we will add them to adyen paylaod

788ed68

maarcingebala merged commit 90e4703 into master Oct 30, 2020

maarcingebala deleted the SALEOR-1454-improve-aproval-rate-for-adyen branch October 30, 2020 10:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve aproval rate for adyen requests #6315

Improve aproval rate for adyen requests #6315

korycins commented Oct 23, 2020 •

edited

codecov bot commented Oct 23, 2020 •

edited

db-queries bot commented Oct 23, 2020 •

edited

Improve aproval rate for adyen requests #6315

Improve aproval rate for adyen requests #6315

Conversation

korycins commented Oct 23, 2020 • edited

codecov bot commented Oct 23, 2020 • edited

Codecov Report

db-queries bot commented Oct 23, 2020 • edited

korycins commented Oct 23, 2020 •

edited

codecov bot commented Oct 23, 2020 •

edited

db-queries bot commented Oct 23, 2020 •

edited