-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CheckoutLinesInfoByCheckoutTokenLoader dataloader #6929
Fix CheckoutLinesInfoByCheckoutTokenLoader dataloader #6929
Conversation
Here is the report for 1310744 (mirumee:fix-dataloader-for-getting-checkout-lines-info) Found 8 differences! (click me)
# saleor.graphql.accountbenchmark account
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
delete staff members 32 32 0
query staff user 20 20 4
staff create 22 22 4
staff update groups and permissions 33 33 5
# saleor.graphql.accountbenchmark permission group
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
permission group create 19 19 2
permission group delete 20 20 3
permission group query 7 7 0
permission group update 33 33 1
permission group update remove users with manage staff 27 27 3
# saleor.graphql.attributebenchmark attribute
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
query attribute 7 7 2
query attributes 11 11 3
# saleor.graphql.checkoutbenchmark checkout mutations
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
- add billing address to checkout 53 54 8
- add shipping to checkout 64 65 12
- checkout email update 26 27 3
checkout payment charge 34 34 11
- checkout shipping address update 64 65 12
- checkout voucher code 64 65 10
complete checkout 94 94 20
- create checkout 79 80 16
customer complete checkout 131 131 34
- update checkout lines 93 94 24
# saleor.graphql.checkoutbenchmark homepage
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
- user checkout details 39 40 2
# saleor.graphql.discountbenchmark sales
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
sales query with channel slug 16 16 0
sales query withot channel slug 15 15 0
# saleor.graphql.discountbenchmark vouchers
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
vouchers query with channel slug 16 16 0
vouchers query withot channel slug 15 15 0
# saleor.graphql.menubenchmark homepage
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
retrieve main menu 5 5 0
retrieve secondary menu 5 5 0
# saleor.graphql.orderbenchmark fulfillment refund and return products
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
fulfillment refund products order lines 46 46 2
fulfillment return products order lines 99 99 11
# saleor.graphql.orderbenchmark order
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
user order details 22 22 1
# saleor.graphql.pagebenchmark page type
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
query page type 17 17 5
query page types 19 19 5
# saleor.graphql.productbenchmark category
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
category view 24 24 1
# saleor.graphql.productbenchmark collection
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
collection view 6 6 0
retrieve collection channel listings 4 4 0
# saleor.graphql.productbenchmark homepage
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
report product sales 10 10 3
retrieve product list 4 4 0
# saleor.graphql.productbenchmark product
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
product details 26 26 0
retrieve channel listings 18 18 0
retrieve product attributes 8 8 0
retrive products with product types and attributes 6 6 0
# saleor.graphql.productbenchmark variant
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
product variant bulk create 59 59 2
retrieve variant list 24 24 0
# saleor.graphql.productbenchmark variant stocks
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
product variants stocks create 22 22 5
product variants stocks delete 19 19 5
product variants stocks update 27 27 5
# saleor.graphql.producttest product sorting attributes
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
sort product not having attribute data 23 23 0
# saleor.graphql.shippingbenchmark shipping methods
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
vouchers query with channel slug 10 10 0
vouchers query without channel slug 9 9 0
# saleor.graphql.shopbenchmark homepage
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
retrieve shop 2 2 0
|
Codecov Report
@@ Coverage Diff @@
## master #6929 +/- ##
==========================================
- Coverage 92.93% 92.92% -0.02%
==========================================
Files 419 419
Lines 30473 30485 +12
Branches 3114 3117 +3
==========================================
+ Hits 28321 28329 +8
- Misses 1513 1517 +4
Partials 639 639
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the changelog.
Fix
CheckoutLinesInfoByCheckoutTokenLoader
data loader. Previously, data was prepared only for the first key.Impact
Pull Request Checklist