Do not update draft order addresses when user is changing #7088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the report for fd0b590 (mirumee:SALEOR-1491-do-not-update-draft-order-addresses-when-user-is-changing) No differences were found.
# saleor.graphql.accountbenchmark account
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
delete staff members 32 32 0
query staff user 18 18 3
staff create 22 22 3
staff update groups and permissions 32 32 4
# saleor.graphql.accountbenchmark permission group
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
permission group create 19 19 2
permission group delete 20 20 3
permission group query 7 7 0
permission group update 33 33 1
permission group update remove users with manage staff 27 27 3
# saleor.graphql.attributebenchmark attribute
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
query attribute 7 7 2
query attributes 11 11 3
# saleor.graphql.checkoutbenchmark checkout mutations
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
add billing address to checkout 49 49 5
add shipping to checkout 63 63 9
checkout email update 23 23 0
checkout payment charge 39 39 14
checkout shipping address update 75 75 20
checkout voucher code 67 67 10
complete checkout 108 108 13
complete checkout with single line 110 110 13
create checkout 73 73 11
customer complete checkout 153 153 41
update checkout lines 85 85 11
# saleor.graphql.checkoutbenchmark homepage
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
user checkout details 39 39 2
# saleor.graphql.discountbenchmark sales
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
sales query with channel slug 16 16 0
sales query withot channel slug 15 15 0
# saleor.graphql.discountbenchmark vouchers
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
vouchers query with channel slug 16 16 0
vouchers query withot channel slug 15 15 0
# saleor.graphql.orderbenchmark fulfillment refund and return products
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
fulfillment refund products order lines 54 54 3
fulfillment return products order lines 104 104 13
# saleor.graphql.orderbenchmark order
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
staff multiple orders 25 25 0
staff order details 77 77 43
user order details 33 33 3
# saleor.graphql.pagebenchmark page type
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
query page type 17 17 5
query page types 19 19 5
# saleor.graphql.productbenchmark category
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
categories children 3 3 0
category delete 83 83 14
category view 25 25 1
# saleor.graphql.productbenchmark collection
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
collection add products 32 32 5
collection bulk delete 39 39 5
collection view 6 6 0
create collection 32 32 5
delete collection 34 34 6
remove products from collection 29 29 5
retrieve collection channel listings 4 4 0
# saleor.graphql.productbenchmark homepage
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
report product sales 10 10 3
retrieve product list 4 4 0
# saleor.graphql.productbenchmark product
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
product create 68 68 3
product details 30 30 0
retrieve channel listings 18 18 0
retrieve product attributes 8 8 0
retrieve product images 3 3 0
retrieve product media 3 3 0
retrive products with product types and attributes 6 6 0
update product 33 33 3
# saleor.graphql.productbenchmark product variant channel listing update
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
variant channel listing update 48 48 4
# saleor.graphql.productbenchmark variant
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
product variant bulk create 62 62 2
product variant create 74 74 6
retrieve variant list 24 24 0
update product variant 76 76 10
# saleor.graphql.productbenchmark variant stocks
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
product variants stocks create 22 22 5
product variants stocks delete 19 19 5
product variants stocks update 27 27 5
query product variants stocks 14 14 4
# saleor.graphql.producttest product sorting attributes
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
sort product not having attribute data 23 23 0
# saleor.graphql.shippingbenchmark shipping methods
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
vouchers query with channel slug 10 10 0
vouchers query without channel slug 9 9 0
# saleor.graphql.shopbenchmark homepage
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
retrieve shop 6 6 0
|
Codecov Report
@@ Coverage Diff @@
## master #7088 +/- ##
==========================================
+ Coverage 93.31% 93.33% +0.02%
==========================================
Files 455 455
Lines 33480 33492 +12
Branches 3412 3412
==========================================
+ Hits 31243 31261 +18
+ Misses 1552 1547 -5
+ Partials 685 684 -1
Continue to review full report at Codecov.
|
|
Blocked by: https://app.clickup.com/t/2549495/SALEOR-2798 |
…esses-when-user-is-changing
…esses-when-user-is-changing
5 tasks
github-actions
bot
temporarily deployed
to
saleor-1491-do-not-update-draft-order-addresses-when-user-is-ch
fowczarek
approved these changes
Apr 29, 2021
maarcingebala
approved these changes
May 5, 2021
maarcingebala
deleted the
SALEOR-1491-do-not-update-draft-order-addresses-when-user-is-changing
branch
maarcingebala
pushed a commit
that referenced
this pull request
May 11, 2021
* Do not update draft order adresses when user is changing * Update changelog * Update address validation - return also address type that causes the error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not update draft order addresses when the user is changing - the addresses should be provided in the input.
Should be merged together with dashboard changes.
Impact
Pull Request Checklist