Feature/plugins per channel #7198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Extend manager to use channel * Add missing conftest * Add tests * Add draft note to changelog * use channel slug already assigned to variable
* Add migration to add channel to plugin configuration * Fix migrations which were importing manager * Change on_delete from null to cascade * Extend manager to use channel * Add missing conftest * Add tests * Add draft note to changelog * Refactor code to handle a plugins per channel * Add more tests for pluginUpdate mutation * Update changelog * Feature/extend manager to use channel slug (#7118) * Extend manager to use channel * Add missing conftest * Add tests * Add draft note to changelog * use channel slug already assigned to variable * Apply changes after review
korycins
added
feature branch
test deployment
github-actions
bot
temporarily deployed
to
feature-plugins-per-channel
|
Here is the report for 1be2173 (mirumee:feature/plugins_per_channel) Found 40 differences! (click me)
# saleor.graphql.accountbenchmark account
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
delete staff members 32 32 0
query staff user 18 18 3
- staff create 22 23 3
staff update groups and permissions 32 32 4
# saleor.graphql.accountbenchmark permission group
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
permission group create 19 19 2
permission group delete 20 20 3
permission group query 7 7 0
permission group update 33 33 1
permission group update remove users with manage staff 27 27 3
# saleor.graphql.attributebenchmark attribute
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
query attribute 7 7 2
query attributes 11 11 3
# saleor.graphql.checkoutbenchmark checkout mutations
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
- add billing address to checkout 49 51 5
- add shipping to checkout 63 64 9
- checkout email update 23 25 0
- checkout payment charge 39 42 16
- checkout shipping address update 68 69 12
- checkout voucher code 67 68 10
- complete checkout 107 108 13
- complete checkout with single line 109 110 13
- create checkout 71 72 11
- customer complete checkout 152 153 41
- update checkout lines 82 83 14
# saleor.graphql.checkoutbenchmark homepage
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
- user checkout details 39 41 2
# saleor.graphql.discountbenchmark sales
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
sales query with channel slug 16 16 0
sales query withot channel slug 15 15 0
# saleor.graphql.discountbenchmark vouchers
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
vouchers query with channel slug 16 16 0
vouchers query withot channel slug 15 15 0
# saleor.graphql.orderbenchmark fulfillment refund and return products
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
- fulfillment refund products order lines 54 55 3
- fulfillment return products order lines 104 106 14
# saleor.graphql.orderbenchmark order
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
staff multiple orders 25 25 0
- staff order details 77 78 43
- user order details 33 34 3
# saleor.graphql.pagebenchmark page type
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
query page type 17 17 5
query page types 19 19 5
# saleor.graphql.productbenchmark category
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
categories children 3 3 0
- category delete 83 84 14
- category view 25 26 1
# saleor.graphql.productbenchmark collection
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
- collection add products 32 33 5
- collection bulk delete 39 40 5
- collection view 6 7 0
- create collection 32 33 5
- delete collection 34 35 6
- remove products from collection 29 30 5
retrieve collection channel listings 4 4 0
# saleor.graphql.productbenchmark homepage
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
report product sales 10 10 3
retrieve product list 4 4 0
# saleor.graphql.productbenchmark product
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
- filter products by attributes 8 9 0
- filter products by numeric attributes 17 18 0
- product create 68 69 3
- product details 30 31 0
- retrieve channel listings 18 19 0
- retrieve product attributes 8 9 0
- retrieve product images 3 4 0
- retrieve product media 3 4 0
- retrive products with product types and attributes 6 7 0
- update product 33 34 3
# saleor.graphql.productbenchmark product variant channel listing update
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
- variant channel listing update 48 49 4
# saleor.graphql.productbenchmark variant
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
- product variant bulk create 62 63 2
- product variant create 74 75 6
- retrieve variant list 24 25 0
- update product variant 76 77 10
# saleor.graphql.productbenchmark variant stocks
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
product variants stocks create 22 22 5
product variants stocks delete 19 19 5
product variants stocks update 27 27 5
query product variants stocks 14 14 4
# saleor.graphql.producttest product sorting attributes
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
sort product not having attribute data 23 23 0
# saleor.graphql.shippingbenchmark shipping methods
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
vouchers query with channel slug 10 10 0
vouchers query without channel slug 9 9 0
# saleor.graphql.shopbenchmark homepage
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
retrieve shop 6 6 0
|
github-actions
bot
temporarily deployed
to
feature-plugins-per-channel
Codecov Report
@@ Coverage Diff @@
## master #7198 +/- ##
========================================
Coverage 93.36% 93.36%
========================================
Files 456 457 +1
Lines 33674 33894 +220
Branches 3435 3462 +27
========================================
+ Hits 31439 31646 +207
- Misses 1547 1559 +12
- Partials 688 689 +1
Continue to review full report at Codecov.
|
Allow to configure user emails plugins per channel
github-actions
bot
temporarily deployed
to
feature-plugins-per-channel
github-actions
bot
temporarily deployed
to
feature-plugins-per-channel
* Update the logic to use filters with multichannels * Fix tests after changes in plugin filters * Update changelog with the details related to new way of filtering * Remove commented code
github-actions
bot
temporarily deployed
to
feature-plugins-per-channel
* Extend notify method to handle channel slug as an input * Update a changelog
github-actions
bot
temporarily deployed
to
feature-plugins-per-channel
github-actions
bot
temporarily deployed
to
feature-plugins-per-channel
korycins
added
test deployment
fowczarek
approved these changes
May 6, 2021
|
FYI: We are waiting for small changes in the storefront before we will merge it. |
5 tasks
maarcingebala
approved these changes
May 10, 2021
maarcingebala
added
the
approved-breaking-change
korycins
added
test deployment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to merge this change because it adds support for configuring plugins per channel
Impact
Pull Request Checklist