Set authorize.net order description to graphql_payment_id for cross referencing #7605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
David Burke seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Here is the report for 4034cb4 (bufke:authorize_net_graphql_payment_id) No differences were found.
# saleor.graphql.accountbenchmark account
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
customers query 48 48 0
delete staff members 32 32 0
query staff user 18 18 3
staff create 23 23 3
staff update groups and permissions 32 32 4
# saleor.graphql.accountbenchmark permission group
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
permission group create 19 19 2
permission group delete 20 20 3
permission group query 7 7 0
permission group update 33 33 1
permission group update remove users with manage staff 27 27 3
# saleor.graphql.attributebenchmark attribute
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
attribute translation 5 5 0
attribute value translation 26 26 0
query attribute 6 6 0
query attributes 8 8 0
# saleor.graphql.checkoutbenchmark checkout mutations
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
add billing address to checkout 51 51 5
add checkout lines 49 49 8
add shipping to checkout 64 64 9
checkout email update 25 25 0
checkout payment charge 42 42 16
checkout shipping address update 69 69 13
checkout voucher code 70 70 12
complete checkout 109 109 13
complete checkout with single line 111 111 13
create checkout 73 73 12
customer complete checkout 155 155 42
update checkout lines 51 51 8
# saleor.graphql.checkoutbenchmark homepage
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
user checkout details 41 41 2
# saleor.graphql.discountbenchmark sales
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
sales query with channel slug 16 16 0
sales query withot channel slug 15 15 0
# saleor.graphql.discountbenchmark vouchers
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
vouchers query with channel slug 16 16 0
vouchers query withot channel slug 15 15 0
# saleor.graphql.orderbenchmark fulfillment refund and return products
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
fulfillment refund products order lines 53 53 2
fulfillment return products order lines 101 101 14
# saleor.graphql.orderbenchmark order
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
staff multiple draft orders 402 402 308
staff multiple orders 152 152 76
staff order details 46 46 7
user order details 42 42 7
# saleor.graphql.pagebenchmark page type
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
query page type 19 19 7
query page types 25 25 12
# saleor.graphql.productbenchmark category
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
categories children 3 3 0
category delete 108 108 27
category view 27 27 1
# saleor.graphql.productbenchmark collection
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
collection add products 44 44 10
collection bulk delete 51 51 10
collection view 6 6 0
create collection 47 47 12
delete collection 46 46 11
remove products from collection 41 41 10
retrieve collection channel listings 4 4 0
# saleor.graphql.productbenchmark homepage
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
report product sales 10 10 3
retrieve product list 4 4 0
# saleor.graphql.productbenchmark product
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
filter products by attributes 9 9 0
filter products by boolean attributes 19 19 0
filter products by numeric attributes 18 18 0
product create 70 70 3
product details 31 31 0
product translations 5 5 0
retrieve channel listings 19 19 0
retrieve product attributes 9 9 0
retrieve product images 4 4 0
retrieve product media 4 4 0
retrive products with product types and attributes 7 7 0
update product 46 46 4
# saleor.graphql.productbenchmark product variant channel listing update
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
variant channel listing update 50 50 5
# saleor.graphql.productbenchmark variant
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
product variant bulk create 63 63 2
product variant create 75 75 6
retrieve variant list 25 25 0
update product variant 79 79 12
# saleor.graphql.productbenchmark variant stocks
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
product variants stocks create 22 22 5
product variants stocks delete 19 19 5
product variants stocks update 27 27 5
query product variants stocks 14 14 4
# saleor.graphql.producttest product sorting attributes
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
sort product not having attribute data 23 23 0
# saleor.graphql.shippingbenchmark shipping methods
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
vouchers query with channel slug 10 10 0
vouchers query without channel slug 9 9 0
# saleor.graphql.shopbenchmark homepage
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
retrieve shop 6 6 0
|
Codecov Report
@@ Coverage Diff @@
## master #7605 +/- ##
==========================================
- Coverage 93.33% 93.32% -0.02%
==========================================
Files 462 462
Lines 34925 34941 +16
Branches 3602 3604 +2
==========================================
+ Hits 32596 32607 +11
- Misses 1614 1618 +4
- Partials 715 716 +1
Continue to review full report at Codecov.
|
|
You should have my CLA on file, I may have submitted it before this bot was set up. The codecov change is only from going from a empty string to a existing variable. |
korycins
approved these changes
Jul 9, 2021
tomaszszymanski129
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's helpful to reference a Saleor order from authorize.net. However when payment takes place, Saleor does not have a Order number yet. This mitigates the problem by assigning the Saleor payment graphql ID to the Authorize.net Order description field. It leaves the Order Invoice Number set to payment_information order_id in case in the future we can assign the actual Order ID.
Impact
Pull Request Checklist