Custom prices

[IKarbowiak]

Allow defining checkout items custom prices.

Docs: saleor/saleor-docs#390

• Add HANDLE_CHECKOUTS permission.
  • The new permission is granted to all apps and groups that already have MANAGE_CHECKOUT.
• The CheckoutLineInput is extended with the optional price field price: PositiveDecimal, so the custom price could be set in the following mutations:
  • checkoutCreate
  • checkoutLinesAdd - when adding a variant that is already added to checkout, the already existing line is overridden - the quantity is incremented and the price is updated.
  • checkoutLinesUpdate - overrides the existing line with the price provided in the mutation
• Update all places where the checkout price is calculated to use price_override if set.
• Extend populate db with checkout with custom prices.

Impact

• New migrations
• New/Updated API fields or mutations
• Deprecated API fields or mutations
• Removed API types, fields, or mutations
• Documentation needs to be updated

Pull Request Checklist

• Privileged queries and mutations are guarded by proper permission checks
• Database queries are optimized and the number of queries is constant
• Database migration files are up to date
• The changes are tested
• GraphQL schema and type definitions are up to date
• Changes are mentioned in the changelog

[patrys]

Task linked: SALEOR-6089 Custom prices when adding items to checkout

[db-queries]

Here is the report for d6c0444 (saleor:SALEOR-6089-custom-prices)
Base comparison is 2675fda.

No differences were found.

# saleor.graphql.accountbenchmark account
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  addresses for federation query count                                    	          9	          9	              2
  customers query                                                         	         48	         48	              0
  delete staff members                                                    	         35	         35	              0
  query staff user                                                        	         18	         18	              3
  staff create                                                            	         23	         23	              3
  staff update groups and permissions                                     	         35	         35	              5
  users for federation query count                                        	          8	          8	              3

# saleor.graphql.accountbenchmark permission group
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  groups for federation query count                                       	          5	          5	              2
  permission group create                                                 	         21	         21	              2
  permission group delete                                                 	         22	         22	              3
  permission group query                                                  	          7	          7	              0
  permission group update                                                 	         35	         35	              1
  permission group update remove users with manage staff                  	         29	         29	              3

# saleor.graphql.appbenchmarks app extensions
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  app extensions                                                          	         15	         15	              0
  app extensions with filter[filter0]                                     	         14	         14	              0
  app extensions with filter[filter1]                                     	         10	         10	              0
  app extensions with filter[filter2]                                     	         14	         14	              0
  app extensions with filter[filter3]                                     	         10	         10	              0

# saleor.graphql.appbenchmarks apps
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  apps for federation query count                                         	          9	          9	              3

# saleor.graphql.attributebenchmark attribute
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  attribute translation                                                   	          6	          6	              0
  attribute value translation                                             	         26	         26	              0
  query attribute                                                         	          6	          6	              0
  query attributes                                                        	          8	          8	              0

# saleor.graphql.checkoutbenchmark checkout mutations
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  add billing address to checkout                                         	         46	         46	              4
  add checkout lines                                                      	         56	         56	              4
  add checkout lines with external shipping                               	         95	         95	             15
  add checkout lines with reservations                                    	        120	        120	             38
  add delivery to checkout                                                	         60	         60	              8
  add shipping to checkout                                                	         63	         63	              8
  checkout email update                                                   	         26	         26	              0
  checkout payment charge                                                 	         40	         40	             15
  checkout shipping address update                                        	         65	         65	             12
  checkout voucher code                                                   	         67	         67	             10
  complete checkout                                                       	        139	        139	             23
  complete checkout preorder                                              	        157	        157	             35
  complete checkout with digital line                                     	        199	        199	             49
  complete checkout with out of stock webhook                             	        141	        141	             23
  complete checkout with single line                                      	        141	        141	             23
  create checkout                                                         	         69	         69	             10
  create checkout for cc                                                  	         64	         64	              8
  create checkout with reservations                                       	        117	        117	             20
  customer complete checkout                                              	        154	        154	             27
  customer complete checkout for cc                                       	        157	        157	             30
  update checkout lines                                                   	         49	         49	              4
  update checkout lines with reservations                                 	        124	        124	             49

# saleor.graphql.checkoutbenchmark homepage
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  user checkout details                                                   	         36	         36	              2

# saleor.graphql.discountbenchmark sales
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  sales query with channel slug                                           	         19	         19	              0
  sales query withot channel slug                                         	         18	         18	              0

# saleor.graphql.discountbenchmark vouchers
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  vouchers query with channel slug                                        	         19	         19	              0
  vouchers query withot channel slug                                      	         18	         18	              0

# saleor.graphql.giftcardbenchmark gift card mutations
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  create never expiry gift card                                           	         28	         28	              4
  gift card bulk activate by staff                                        	         15	         15	              3
  update gift card                                                        	         36	         36	              4

# saleor.graphql.giftcardbenchmark gift card queries
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  filter gift cards by products                                           	         14	         14	              3
  filter gift cards by tags                                               	         12	         12	              3
  filter gift cards by used by user                                       	         13	         13	              3
  query gift card details                                                 	         14	         14	              3
  query gift cards                                                        	         12	         12	              3

# saleor.graphql.orderbenchmark fulfillment refund and return products
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  fulfillment refund products order lines                                 	         55	         55	              2
  fulfillment return products order lines                                 	        108	        108	             14

# saleor.graphql.orderbenchmark order
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  staff multiple draft orders                                             	        539	        539	            445
  staff multiple orders                                                   	        159	        159	             86
  staff order details                                                     	         45	         45	              8
  user order details                                                      	         43	         43	              9

# saleor.graphql.orderbenchmark order fulfill
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  order fulfill                                                           	         19	         19	              3
  order fulfill with gift cards                                           	         19	         19	              3

# saleor.graphql.pagebenchmark page type
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  page types for federation query count                                   	          3	          3	              0
  query page type                                                         	         18	         18	              6
  query page types                                                        	         25	         25	             12

# saleor.graphql.productbenchmark category
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  categories children                                                     	          3	          3	              0
  categories for federation query count                                   	          3	          3	              0
  category delete                                                         	         85	         85	             16
  category view                                                           	         26	         26	              1

# saleor.graphql.productbenchmark collection
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  collection add products                                                 	         36	         36	              6
  collection bulk delete                                                  	         47	         47	              8
  collection view                                                         	          6	          6	              0
  collections for federation query count                                  	          7	          7	              2
  create collection                                                       	         36	         36	              5
  delete collection                                                       	         39	         39	              7
  remove products from collection                                         	         33	         33	              6
  retrieve collection channel listings                                    	          5	          5	              0

# saleor.graphql.productbenchmark homepage
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  report product sales                                                    	         10	         10	              3
  retrieve product list                                                   	          4	          4	              0

# saleor.graphql.productbenchmark product
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  filter products by attributes                                           	          9	          9	              0
  filter products by boolean attributes                                   	         19	         19	              0
  filter products by gift card                                            	         11	         11	              1
  filter products by numeric attributes                                   	         18	         18	              0
  product create                                                          	         73	         73	              8
  product details                                                         	         33	         33	              0
  product translations                                                    	          5	          5	              0
  products for federation query count                                     	          6	          6	              2
  products media for federation query count                               	          3	          3	              0
  products types for federation query count                               	          2	          2	              0
  retrieve channel listings                                               	         17	         17	              0
  retrieve product attributes                                             	          9	          9	              0
  retrieve product images                                                 	          4	          4	              0
  retrieve product media                                                  	          4	          4	              0
  retrive products with product types and attributes                      	          7	          7	              0
  update product                                                          	         51	         51	             11

# saleor.graphql.productbenchmark product variant channel listing update
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  variant channel listing update                                          	         45	         45	              3

# saleor.graphql.productbenchmark variant
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  product variant bulk create                                             	         66	         66	              3
  product variant create                                                  	         80	         80	              5
  products variants for federation query count                            	          6	          6	              2
  retrieve variant list                                                   	         28	         28	              2
  update product variant                                                  	         78	         78	              9

# saleor.graphql.productbenchmark variant stocks
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  product variants stocks create                                          	         27	         27	              5
  product variants stocks create with single webhook called               	         25	         25	              5
  product variants stocks delete                                          	         27	         27	              5
  product variants stocks delete with out of stock webhook many calls     	         23	         23	              3
  product variants stocks update                                          	         29	         29	              5
  query product variants stocks                                           	         10	         10	              0

# saleor.graphql.producttest product sorting attributes
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  sort product not having attribute data                                  	         23	         23	              0

# saleor.graphql.shippingbenchmark shipping methods
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  vouchers query with channel slug                                        	          9	          9	              0
  vouchers query without channel slug                                     	          9	          9	              0

# saleor.graphql.shopbenchmark homepage
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  retrieve shop                                                           	          4	          4	              0

[codecov]

Codecov Report

Merging #9393 (d6c0444) into main (f5cfc7e) will increase coverage by 0.00%.
The diff coverage is 97.16%.

@@           Coverage Diff           @@
##             main    #9393   +/-   ##
=======================================
  Coverage   93.22%   93.23%           
=======================================
  Files         552      552           
  Lines       43702    43778   +76     
  Branches     7374     7393   +19     
=======================================
+ Hits        40741    40816   +75     
  Misses       1923     1923           
- Partials     1038     1039    +1     

Impacted Files	Coverage Δ
saleor/checkout/base_calculations.py	97.01% <ø> (ø)
saleor/checkout/fetch.py	97.57% <ø> (ø)
...r/graphql/checkout/mutations/checkout_lines_add.py	98.41% <75.00%> (+0.05%)	⬆️
...leor/graphql/checkout/mutations/checkout_create.py	97.70% <88.88%> (+0.07%)	⬆️
saleor/checkout/utils.py	93.75% <97.14%> (+0.08%)	⬆️
saleor/checkout/complete_checkout.py	87.91% <100.00%> (+0.10%)	⬆️
saleor/checkout/models.py	97.19% <100.00%> (+0.02%)	⬆️
...raphql/checkout/mutations/checkout_lines_update.py	100.00% <100.00%> (ø)
saleor/graphql/checkout/mutations/utils.py	93.54% <100.00%> (+1.65%)	⬆️
saleor/product/models.py	94.10% <100.00%> (+0.03%)	⬆️
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5cfc7e...d6c0444. Read the comment docs.

[korycins]

@IKarbowiak Question. How do we want to handle such a case? (Or just confirm that we are able to do that)

• User creates checkout with item A
• User adds an item B
• A+B means that for some reason we want to reduce the value of each of these lines
• App with Handle_checkouts recieve webhook checkout_updated (OR storefront triggers notification to app, that we want to have override prices), and because of the above condition it wants to change prices for these lines but without touching their quantity. Is it possible? (Maybe I am wrong, but not sure if this is possible currently).

[IKarbowiak]

@korycins Thank you for mentioning this case. The CheckoutLinesUpdate is for that, but I need to make some changes as it requires the CheckoutLineInput where quantity is required. Because of that, I'm changing the PR into a draft.