Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate order line id from int to UUID #9637

Merged
merged 12 commits into from May 10, 2022

Conversation

IKarbowiak
Copy link
Member

Change order line id from int to UUID.

Impact

  • New migrations
  • New/Updated API fields or mutations
  • Deprecated API fields or mutations
  • Removed API types, fields, or mutations
  • Documentation needs to be updated

Pull Request Checklist

  • Privileged queries and mutations are guarded by proper permission checks
  • Database queries are optimized and the number of queries is constant
  • Database migration files are up to date
  • The changes are tested
  • GraphQL schema and type definitions are up to date
  • Changes are mentioned in the changelog

@patrys
Copy link
Member

patrys commented Apr 27, 2022

Task linked: SALEOR-6544 Migrate orderLine ID to UUID

@IKarbowiak IKarbowiak changed the title Migrate order line id to UUID Migrate order line id from int to UUID Apr 27, 2022
@IKarbowiak IKarbowiak self-assigned this Apr 27, 2022
@db-queries
Copy link

db-queries bot commented Apr 27, 2022

Here is the report for 828405a (saleor:SALEOR-6544-migrate-order-line-id-to-uuid)
Missing base report (cc728ef). The results couldn't be compared.

No differences were found.

# saleor.graphql.accountbenchmark account
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  addresses for federation query count                                    	          9	          9	              2
  customers query                                                         	         48	         48	              0
  delete staff members                                                    	         35	         35	              0
  query staff user                                                        	         18	         18	              3
  staff create                                                            	         23	         23	              3
  staff update groups and permissions                                     	         35	         35	              5
  users for federation query count                                        	          8	          8	              3

# saleor.graphql.accountbenchmark permission group
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  groups for federation query count                                       	          5	          5	              2
  permission group create                                                 	         21	         21	              2
  permission group delete                                                 	         22	         22	              3
  permission group query                                                  	          7	          7	              0
  permission group update                                                 	         35	         35	              1
  permission group update remove users with manage staff                  	         29	         29	              3

# saleor.graphql.appbenchmarks app extensions
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  app extensions                                                          	         15	         15	              0
  app extensions with filter[filter0]                                     	         14	         14	              0
  app extensions with filter[filter1]                                     	         10	         10	              0
  app extensions with filter[filter2]                                     	         14	         14	              0
  app extensions with filter[filter3]                                     	         10	         10	              0

# saleor.graphql.appbenchmarks apps
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  apps for federation query count                                         	          9	          9	              3

# saleor.graphql.attributebenchmark attribute
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  attribute translation                                                   	          6	          6	              0
  attribute value translation                                             	         26	         26	              0
  query attribute                                                         	          6	          6	              0
  query attributes                                                        	          8	          8	              0

# saleor.graphql.checkoutbenchmark checkout mutations
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  add billing address to checkout                                         	         46	         46	              4
  add checkout lines                                                      	         56	         56	              4
  add checkout lines with external shipping                               	         92	         92	             13
  add checkout lines with reservations                                    	        120	        120	             38
  add delivery to checkout                                                	         60	         60	              8
  add shipping to checkout                                                	         63	         63	              8
  checkout email update                                                   	         26	         26	              0
  checkout payment charge                                                 	         40	         40	             15
  checkout shipping address update                                        	         65	         65	             11
  checkout voucher code                                                   	         67	         67	             10
  complete checkout                                                       	        142	        142	             23
  complete checkout preorder                                              	        160	        160	             35
  complete checkout with digital line                                     	        202	        202	             49
  complete checkout with out of stock webhook                             	        144	        144	             23
  complete checkout with single line                                      	        144	        144	             23
  create checkout                                                         	         69	         69	             10
  create checkout for cc                                                  	         64	         64	              8
  create checkout with reservations                                       	        118	        118	             20
  customer complete checkout                                              	        157	        157	             27
  customer complete checkout for cc                                       	        160	        160	             30
  update checkout lines                                                   	         49	         49	              4
  update checkout lines with reservations                                 	        124	        124	             49

# saleor.graphql.checkoutbenchmark homepage
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  user checkout details                                                   	         36	         36	              2

# saleor.graphql.discountbenchmark sales
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  sales query with channel slug                                           	         19	         19	              0
  sales query withot channel slug                                         	         18	         18	              0

# saleor.graphql.discountbenchmark vouchers
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  vouchers query with channel slug                                        	         19	         19	              0
  vouchers query withot channel slug                                      	         18	         18	              0

# saleor.graphql.giftcardbenchmark gift card mutations
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  create never expiry gift card                                           	         28	         28	              4
  gift card bulk activate by staff                                        	         16	         16	              3
  update gift card                                                        	         36	         36	              4

# saleor.graphql.giftcardbenchmark gift card queries
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  filter gift cards by products                                           	         14	         14	              3
  filter gift cards by tags                                               	         12	         12	              3
  filter gift cards by used by user                                       	         13	         13	              3
  query gift card details                                                 	         14	         14	              3
  query gift cards                                                        	         12	         12	              3

# saleor.graphql.orderbenchmark fulfillment refund and return products
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  fulfillment refund products order lines                                 	         56	         56	              2
  fulfillment return products order lines                                 	        109	        109	             14

# saleor.graphql.orderbenchmark order
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  staff multiple draft orders                                             	        540	        540	            436
  staff multiple orders                                                   	        160	        160	             86
  staff order details                                                     	         46	         46	              8
  user order details                                                      	         44	         44	              9

# saleor.graphql.orderbenchmark order fulfill
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  order fulfill                                                           	         19	         19	              3
  order fulfill with gift cards                                           	         19	         19	              3

# saleor.graphql.pagebenchmark page type
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  page types for federation query count                                   	          3	          3	              0
  query page type                                                         	         18	         18	              6
  query page types                                                        	         25	         25	             12

# saleor.graphql.productbenchmark category
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  categories children                                                     	          3	          3	              0
  categories for federation query count                                   	          3	          3	              0
  category delete                                                         	         86	         86	             16
  category view                                                           	         26	         26	              1

# saleor.graphql.productbenchmark collection
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  collection add products                                                 	         36	         36	              6
  collection bulk delete                                                  	         47	         47	              8
  collection view                                                         	          6	          6	              0
  collections for federation query count                                  	          7	          7	              2
  create collection                                                       	         36	         36	              5
  delete collection                                                       	         39	         39	              7
  remove products from collection                                         	         33	         33	              6
  retrieve collection channel listings                                    	          5	          5	              0

# saleor.graphql.productbenchmark homepage
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  report product sales                                                    	         10	         10	              3
  retrieve product list                                                   	          4	          4	              0

# saleor.graphql.productbenchmark product
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  filter products by attributes                                           	          9	          9	              0
  filter products by boolean attributes                                   	         19	         19	              0
  filter products by gift card                                            	         11	         11	              1
  filter products by numeric attributes                                   	         18	         18	              0
  product create                                                          	         73	         73	              8
  product details                                                         	         33	         33	              0
  product translations                                                    	          5	          5	              0
  products for federation query count                                     	          6	          6	              2
  products media for federation query count                               	          3	          3	              0
  products types for federation query count                               	          2	          2	              0
  retrieve channel listings                                               	         17	         17	              0
  retrieve product attributes                                             	          9	          9	              0
  retrieve product images                                                 	          4	          4	              0
  retrieve product media                                                  	          4	          4	              0
  retrive products with product types and attributes                      	          7	          7	              0
  update product                                                          	         51	         51	             11

# saleor.graphql.productbenchmark product variant channel listing update
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  variant channel listing update                                          	         45	         45	              3

# saleor.graphql.productbenchmark variant
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  product variant bulk create                                             	         66	         66	              3
  product variant create                                                  	         80	         80	              5
  products variants for federation query count                            	          6	          6	              2
  retrieve variant list                                                   	         28	         28	              2
  update product variant                                                  	         78	         78	              9

# saleor.graphql.productbenchmark variant stocks
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  product variants stocks create                                          	         26	         26	              4
  product variants stocks create with single webhook called               	         25	         25	              4
  product variants stocks delete                                          	         27	         27	              4
  product variants stocks delete with out of stock webhook many calls     	         23	         23	              3
  product variants stocks update                                          	         28	         28	              4
  query product variants stocks                                           	         10	         10	              0

# saleor.graphql.producttest product sorting attributes
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  sort product not having attribute data                                  	         23	         23	              0

# saleor.graphql.shippingbenchmark shipping methods
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  vouchers query with channel slug                                        	          9	          9	              0
  vouchers query without channel slug                                     	          9	          9	              0

# saleor.graphql.shopbenchmark homepage
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  retrieve shop                                                           	          4	          4	              0

# saleor.graphql.warehousebenchmark stocks
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  stocks query                                                            	          5	          5	              0

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #9637 (cc728ef) into main (a1a7a22) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head cc728ef differs from pull request most recent head 828405a. Consider uploading reports for the commit 828405a to get more accurate results

@@           Coverage Diff           @@
##             main    #9637   +/-   ##
=======================================
  Coverage   93.22%   93.22%           
=======================================
  Files         557      557           
  Lines       44987    44990    +3     
  Branches     7599     7599           
=======================================
+ Hits        41939    41942    +3     
  Misses       1962     1962           
  Partials     1086     1086           
Impacted Files Coverage Δ
saleor/app/types.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1a7a22...828405a. Read the comment docs.

@IKarbowiak IKarbowiak force-pushed the SALEOR-6544-migrate-order-line-id-to-uuid branch from 7e5e3dc to 06cac96 Compare April 28, 2022 10:43
@IKarbowiak IKarbowiak marked this pull request as ready for review April 28, 2022 11:18
CHANGELOG.md Outdated Show resolved Hide resolved
@IKarbowiak IKarbowiak requested a review from a team May 2, 2022 08:42
@IKarbowiak IKarbowiak force-pushed the SALEOR-6544-migrate-order-line-id-to-uuid branch from f16aeb5 to ca9a308 Compare May 2, 2022 09:55
@maarcingebala maarcingebala requested a review from a team May 4, 2022 15:13
@IKarbowiak IKarbowiak force-pushed the SALEOR-6544-migrate-order-line-id-to-uuid branch from e215131 to 8739fe3 Compare May 5, 2022 07:36
@IKarbowiak IKarbowiak force-pushed the SALEOR-6544-migrate-order-line-id-to-uuid branch from 8739fe3 to 828405a Compare May 5, 2022 07:37
@maarcingebala maarcingebala merged commit 7223096 into main May 10, 2022
@maarcingebala maarcingebala deleted the SALEOR-6544-migrate-order-line-id-to-uuid branch May 10, 2022 07:39
IKarbowiak added a commit that referenced this pull request May 10, 2022
* Migrate OrderLine ID to UUID

* Migrate line_pk in OrderEvent parmeters to uuid

* Handle old OrderLine id in order mutations

* Fix product migrations conflicts

* Update changelog

* Clean 0024_rewrite_order_line_relations.py migration

* Move changelog record

* Update changelog

* Fix 0139_fulfil_orderline_token_old_id_created_at.py migration

* Update methods for getting node
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants