Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read-only detail views #966

Merged
merged 66 commits into from
Sep 18, 2017
Merged

Read-only detail views #966

merged 66 commits into from
Sep 18, 2017

Conversation

szewczykmira
Copy link
Contributor

@szewczykmira szewczykmira commented Mar 1, 2017

Closes #958
Closes #1011

@codecov-io
Copy link

codecov-io commented Mar 2, 2017

Codecov Report

Merging #966 into master will decrease coverage by 0.23%.
The diff coverage is 39.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #966      +/-   ##
==========================================
- Coverage   63.65%   63.42%   -0.24%     
==========================================
  Files         106      107       +1     
  Lines        5869     5979     +110     
  Branches      729      741      +12     
==========================================
+ Hits         3736     3792      +56     
- Misses       1994     2049      +55     
+ Partials      139      138       -1
Impacted Files Coverage Δ
saleor/dashboard/product/urls.py 100% <ø> (ø) ⬆️
saleor/dashboard/customer/views.py 50% <ø> (ø) ⬆️
saleor/dashboard/category/views.py 23.88% <0%> (ø) ⬆️
saleor/dashboard/order/views.py 39.66% <0%> (ø) ⬆️
saleor/dashboard/product/api.py 58.13% <0%> (ø) ⬆️
saleor/product/utils.py 82.92% <100%> (+3.51%) ⬆️
saleor/dashboard/shipping/urls.py 90.47% <100%> (ø) ⬆️
saleor/dashboard/shipping/views.py 33.33% <12.5%> (-2.57%) ⬇️
saleor/dashboard/product/views.py 18.62% <18.44%> (+0.8%) ⬆️
saleor/dashboard/templatetags/utils.py 52.38% <33.33%> (-3.18%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de2f1a1...96cecb6. Read the comment docs.

@szewczykmira szewczykmira force-pushed the read-only branch 3 times, most recently from 7aaac82 to 2677a89 Compare March 21, 2017 10:11
@subgrafik subgrafik self-assigned this Mar 23, 2017
@subgrafik
Copy link

subgrafik commented Mar 23, 2017

@Product view
image

Product > Variant View
image

Status states:

  • "ready for purchase" - available and in stock
  • "stock running low" - available in stock but one or more variants are not available
  • "out of stock" - not available
  • "not carried" - no records in stock
  • "variants missing" - no variants
  • "not yet available" - available but not current time
  • "not published" - SWITCH IS OFF

Actions
all EDIT buttons → new page form
DELETE → modal
ADD → new page form
SELECT IMAGES (variant) → modal with select

click on stock record line → new page form
on stock edit there is no form for switching stock

Stock - when allocation is higher or same as stock use red color for allert

@maarcingebala
Copy link
Member

maarcingebala commented Apr 13, 2017

We've finished implementation of detail views related to products. A few screenshots showing how they look:

Product details:
zrzut ekranu z 2017-04-13 15-02-47

Variant details:
zrzut ekranu z 2017-04-13 15-05-56

Variant images selection:
zrzut ekranu z 2017-04-13 15-03-50

Stock record details:
zrzut ekranu z 2017-04-13 15-04-13

@patrys
Copy link
Member

patrys commented Apr 14, 2017

Can we add coverage for the newly introduced template tags?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants