Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock pnpm global version in Dockerfiles #275

Closed
lkostrowski opened this issue Jul 28, 2022 · 0 comments · Fixed by #276
Closed

Lock pnpm global version in Dockerfiles #275

lkostrowski opened this issue Jul 28, 2022 · 0 comments · Fixed by #276
Assignees

Comments

@lkostrowski
Copy link
Member

lkostrowski commented Jul 28, 2022

Context

Dockerfile installs pnpm globally in container without locked version.

Contrary to lock files, here each image build will install newest pnpm version from npm.

This introduces risk of errors:

  1. pnpm release may be broken
  2. our code may be incompatible

And it's hard to debug in general.

Since it's on Saleor to maintain working images, we need to ensure stable dependencies

Solution

Find stable, tested version of pnpm and lock it's version in Dockerfile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant