Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock pnpm version in Dockerfile to 7.5.2 #276

Merged
merged 2 commits into from
Jul 28, 2022
Merged

Lock pnpm version in Dockerfile to 7.5.2 #276

merged 2 commits into from
Jul 28, 2022

Conversation

lkostrowski
Copy link
Member

@lkostrowski lkostrowski commented Jul 28, 2022

In the future this should prevent unexpected behavior, when image is downloading newer version than we tested with

In the future this should prevent unexpected behavior, when image is downloading newer version than we tested with
@vercel
Copy link

vercel bot commented Jul 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
deploy-test ✅ Ready (Inspect) Visit Preview Jul 28, 2022 at 8:35AM (UTC)
react-storefront ✅ Ready (Inspect) Visit Preview Jul 28, 2022 at 8:35AM (UTC)
test ✅ Ready (Inspect) Visit Preview Jul 28, 2022 at 8:35AM (UTC)

Dockerfile.dev Outdated Show resolved Hide resolved
Co-authored-by: Michał Miszczyszyn <michal@mmiszy.pl>
@krzysztofwolski
Copy link
Member

krzysztofwolski commented Jul 28, 2022

@lkostrowski maybe we should add ignore flag instead of forcing the exact version?
https://pnpm.io/errors#err_pnpm_peer_dep_issues

@lkostrowski
Copy link
Member Author

lkostrowski commented Jul 28, 2022

@lkostrowski maybe we should add ignore flag instead of forcing the exact version? https://pnpm.io/errors#err_pnpm_peer_dep_issues

I don't think this is a good idea.

There are reasons why package managers are showing errors - we should maintain dependencies versions to work correctly.
If we ignore errors, we can face some silent bugs

The exact version will prevent the case from broken Storefront, caused by Storefront using v6, Dockerfile was installing V7.
I'd like to prevent this in the future. Without a locked version, PNPM can install v8 and break it again.

@typeofweb typeofweb merged commit 518a29e into main Jul 28, 2022
@typeofweb typeofweb deleted the 275-lock-pnpm branch July 28, 2022 09:09
@zaiste
Copy link
Contributor

zaiste commented Jul 28, 2022

The suggested way (their docs) to install pnpm is by using the standalone script. This also locks the version, but it also provides a pre-built binary. A nitpick, but it may help to make it more stable.

@typeofweb
Copy link
Contributor

@zaiste they suggest 5 different ways of installing pnpm. What are the benefits of using a script instead of npm here?
BTW, we're using Corepack on Vercel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Lock pnpm global version in Dockerfiles
4 participants