Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle products without the images at cart and checkout #204

Merged
merged 2 commits into from
May 20, 2022

Conversation

bandieramonte
Copy link
Contributor

@bandieramonte bandieramonte commented May 8, 2022

This PR aims to fix issue 203, so that items without media images can now be added to the cart.

@CLAassistant
Copy link

CLAassistant commented May 8, 2022

CLA assistant check
All committers have signed the CLA.

@vercel
Copy link

vercel bot commented May 8, 2022

@bandieramonte is attempting to deploy a commit to the Saleor Commerce Team on Vercel.

A member of the Team first needs to authorize it.

@matteius
Copy link

matteius commented May 8, 2022

Not sure why the difference, but I am able to add products with out images to the cart. For example: https://mattscoinage.com/default-channel/en-US/products/test-stripe

@bandieramonte
Copy link
Contributor Author

bandieramonte commented May 8, 2022

Not sure why the difference, but I am able to add products with out images to the cart. For example: https://mattscoinage.com/default-channel/en-US/products/test-stripe

Interesting. In any case, I think this new code adds a safety layer for cases without images - it doesn't hurt.
Update: I did note @matteius that the chrome dev tools show a 400 GET error when adding an item without image to the cart in your link.

@github-actions github-actions bot added the Stale label May 17, 2022
@krzysztofwolski krzysztofwolski changed the title Fix issue #203 Handle products without the images at cart and checkout May 20, 2022
Copy link
Member

@krzysztofwolski krzysztofwolski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@krzysztofwolski
Copy link
Member

Tested locally, and indeed it solves the issue with the products without the images :)
Thanks for your contribution!

@krzysztofwolski krzysztofwolski merged commit ba39e71 into saleor:main May 20, 2022
@bandieramonte bandieramonte deleted the fix_issue_203 branch June 1, 2022 14:39
typeofweb pushed a commit that referenced this pull request Jul 27, 2022
Co-authored-by: Krzysztof Wolski <krzysztof.k.wolski@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants