Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relate fields in 8.2.0 not listing when a module's "List " display is selected. In 8.1.3 they list correctly. #181

Open
larrymo opened this issue Nov 24, 2022 · 5 comments
Labels
Area: Frontend Area: Listview Issues & PRs related to all things regarding the Listview Priority:Important Issues & PRs that are important; broken functions; errors; there are workarounds Status: Team Investigating Labels for issues in which the Core Team are investigating / Intend to Investigate Type: Bug Something isn't working

Comments

@larrymo
Copy link

larrymo commented Nov 24, 2022

Issue

This issue is present in several modules.

I modified the "Calls" to add two relate fields. One I called PtrPerson, the other PtrCompany. These were relate fields to Contact and Accounts respectively. I modified the edit and list modules to display these.

Account and contact information was entered and displayed correctly proving the information was entered and saved.

IN 8.2.0 , when going to the Call module, and selecting "List" the Relate information was not displayed.

IN 8.1.3, it was displayed.

Expected Behavior

I expected Suitecrm to display fields linked via Relate to behave themselves and be displayed.

Context

scicali referenced this issue Dec 13, 2022
- Check if relate fields are valid before adding to filter_fields
- Do not add fields with missing definitions
- Do not add non-db fields
@scicali
Copy link

scicali commented Dec 13, 2022

@larrymo as workaround, u can try to comment line 264 in core/backend/Data/LegacyHandler/BaseListDataHandler.php

            if ($type === 'relate' && !$this->isValidRelate($fieldDefinition)) {
                //continue;
            }

@johnM2401 johnM2401 added Type: Bug Something isn't working Priority:Important Issues & PRs that are important; broken functions; errors; there are workarounds Area: Listview Issues & PRs related to all things regarding the Listview labels Jan 17, 2023
@larrymo
Copy link
Author

larrymo commented Jan 22, 2023

The fix of Commenting line 264 resulted in suitecrm failing to load.

However, I noticed that in my version of suitecrm 8.2.2 Line 264 DID NOT have the pair of slashes // before the continue.
Putting these in solved the issue, and allowed the relate fields to be shown correctly.

@scicali
Copy link

scicali commented Jan 23, 2023

@larrymo is a workaround, not a fix, bug is open. It's a suggestion from a user (I'm not a developer!)

@clemente-raposo clemente-raposo added Status: Team Investigating Labels for issues in which the Core Team are investigating / Intend to Investigate Area: Frontend labels Mar 15, 2023
@lukio
Copy link
Contributor

lukio commented Apr 24, 2023

@clemente-raposo could be this ticket #251 be related?

@larrymo
Copy link
Author

larrymo commented Apr 24, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Area: Listview Issues & PRs related to all things regarding the Listview Priority:Important Issues & PRs that are important; broken functions; errors; there are workarounds Status: Team Investigating Labels for issues in which the Core Team are investigating / Intend to Investigate Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants