Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subpanel expand collapse unresponsiveness when useTabs to false in detailviewdefs #343

Closed
yunusyerli1 opened this issue Sep 12, 2023 · 0 comments
Labels
Area: Studio Issues & PRs related to all things regarding studio & module builder Priority:Important Issues & PRs that are important; broken functions; errors; there are workarounds Status: Fix Proposed A issue that has a PR related to it that provides a possible resolution Type:Bug Something isn't working

Comments

@yunusyerli1
Copy link
Contributor

Issue

When useTabs flag is set to false in a module's detailviewdefs, tabs and panels might get unresponsive.

Expected Behavior

All tabs should be panels. And any panels with collapsed true needs to get collapsed at initial page load.

Actual Behavior

In intereactions module, there are 2 tabs. When useTabs id set to false, 2 tabs are expected to become panels. But first one stays as tab and second one becomes a panel but second one is not collapsed as it is already marked as collapsed in studio.

Possible Fix

In record content, differ the methods on regarding on layout is panels or tabs.

Steps to Reproduce

  1. In studio, go to intereactions module and set both tabs as panels.
  2. Check collapsed flag on the last panel.
  3. Go to detailviewdefs on related module and set useTabs to false.
  4. Check browser.

Context

After useTabs is set to false, all tabs needs to be panels.
After checking as Collapsed, the panel is expected to see as collapsed state not expanded.

Your Environment

  • SuiteCRM Version used: 8.3.0
  • Browser name and version (e.g. Chrome Version 51.0.2704.63 (64-bit)): Chrome Version 115.0.5790.171 (64-bit)
  • Environment name and version (e.g. MySQL, PHP 7): Wamp Server, PHP 7.4.33, MariaDB 10.4.12
  • Operating System and version (e.g Ubuntu 16.04): Windows 11
@johnM2401 johnM2401 added Type:Bug Something isn't working Priority:Important Issues & PRs that are important; broken functions; errors; there are workarounds Area: Studio Issues & PRs related to all things regarding studio & module builder labels Sep 28, 2023
mpuyosa91 added a commit to yunusyerli1/SuiteCRM-Core that referenced this issue Nov 13, 2023
@gemartin21 gemartin21 added the Status: Fix Proposed A issue that has a PR related to it that provides a possible resolution label Nov 30, 2023
jack7anderson7 pushed a commit to yunusyerli1/SuiteCRM-Core that referenced this issue Jan 22, 2024
jack7anderson7 pushed a commit to yunusyerli1/SuiteCRM-Core that referenced this issue Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Studio Issues & PRs related to all things regarding studio & module builder Priority:Important Issues & PRs that are important; broken functions; errors; there are workarounds Status: Fix Proposed A issue that has a PR related to it that provides a possible resolution Type:Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants