Update scripts deletes files with no warning

[pgorod]

Issue

Currently it seems that the update scripts use a diff to make changes to the SuiteCRM directory, causing any extraneous files and directories to just get deleted without any warning.

In the Forums some people have mentioned this. One person had backups created in the SuiteCRM directory, and they disappeared.

https://community.suitecrm.com/t/filter-using-advanced-filter-date-between-start-date-and-end-date-failed-with-7-14-and-8-5/92644/4?u=pgr

Expected Behavior

• Destructive action should be avoided, if possible.
• If not, the installation should at least refuse to proceed if it detects that things will get deleted. It could have a message something like this:

"Installation cannot continue because there are unknown files or folders that would be deleted. Please move them and try again".

• if that is also not possible, then at least a big flashing red warning should be displayed.

• another possible kind of warning is to use a mandatory switch in the command, something like this:

./bin/console suitecrm:app:upgrade -t SuiteCRM-8.6.0 -deleteAllExtraneousFiles

If that is the only way to proceed and get things installed, then people will necessarily become aware.

[chris001]

Silent 🤭 loss ♻️ 🗑️ of user generated files is bad. 😞