Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX #202 CSRFCookieListener: remove RouteMatcherInterface type property to $routeMatcher #203

Merged
merged 1 commit into from Feb 23, 2023
Merged

FIX #202 CSRFCookieListener: remove RouteMatcherInterface type property to $routeMatcher #203

merged 1 commit into from Feb 23, 2023

Conversation

lukio
Copy link
Contributor

@lukio lukio commented Jan 27, 2023

Description

REL #202

When running bin/console cache:clear command throws a syntax error. I Found that class type property works since PHP 7.4.x . I test it on a PHP 7.3.x environment and throws the syntax error that it's described at #202 issue.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@SuiteBot
Copy link

SuiteBot commented Jan 27, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

clemente-raposo
clemente-raposo previously approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@clemente-raposo clemente-raposo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clemente-raposo clemente-raposo added Status: Requires Testing Status: Passed Code Review Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Team Investigating Labels for issues in which the Core Team are investigating / Intend to Investigate and removed Status: Requires Code Review labels Feb 9, 2023
@clemente-raposo
Copy link
Contributor

clemente-raposo commented Feb 9, 2023 •
edited

Hi @lukio,

Thank you for your PR.

Could you please update the commit message header to something like the following please. Since the commit header was too long for github I took the liberty of writing a small version

Fix #202 - Fix php7.3 compatibility issues in CSRFCookieListener

  • Note only the header of the commit messages needs changed

@lukio
Fix salesagility#202 - Fix php7.3 compatibility issues in CSRFCookieL…
5fc79b6 
…istener

Remove class RouteMatcherInterface type property
at CSRFCookieListener.
@lukio lukio force-pushed the 202-console-cache-clear-throws-syntax-error branch from f9451d5 to 5fc79b6 Compare February 9, 2023 14:42
@lukio
Copy link
Contributor Author

lukio commented Feb 9, 2023

Hi @clemente-raposo

I just fix the commit message header.

johnM2401
johnM2401 approved these changes Feb 15, 2023
View reviewed changes
Copy link

@johnM2401 johnM2401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
./bin/console cache:clear command completes in 7.3/7.4/8.0/8.1/8.2 post-fix.

@clemente-raposo clemente-raposo added Status: Passed Testing and removed Status: Team Investigating Labels for issues in which the Core Team are investigating / Intend to Investigate Status: Requires Testing labels Feb 20, 2023
@clemente-raposo clemente-raposo merged commit 5fb1415 into salesagility:hotfix Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clemente-raposo clemente-raposo clemente-raposo approved these changes

@johnM2401 johnM2401 johnM2401 approved these changes

Assignees
No one assigned
Labels
Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Passed Code Review Status: Passed Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lukio @SuiteBot @clemente-raposo @johnM2401