Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #206 - Email Subject Line #222

Merged
merged 1 commit into from Feb 23, 2023
Merged

Fix #206 - Email Subject Line #222

merged 1 commit into from Feb 23, 2023

Conversation

jack7anderson7
Copy link
Contributor

Description

Fix #206

Motivation and Context

How To Test This

Go to emails and see Subject

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

johnM2401
johnM2401 approved these changes Feb 22, 2023
View reviewed changes
Copy link

@johnM2401 johnM2401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Able to click into Emails Detailview as Admin/Non-Admin, on personal and group Inbounds.

clemente-raposo
clemente-raposo approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@clemente-raposo clemente-raposo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clemente-raposo clemente-raposo added Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Passed Code Review Status: Passed Testing labels Feb 23, 2023
@clemente-raposo clemente-raposo merged commit 76cc3de into hotfix Feb 23, 2023
@mattlorimer mattlorimer deleted the fix/email-subject branch April 10, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clemente-raposo clemente-raposo clemente-raposo approved these changes

@johnM2401 johnM2401 johnM2401 approved these changes

Assignees
No one assigned
Labels
Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Passed Code Review Status: Passed Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

8.2.3 - No link to see emails in Email module
3 participants
@jack7anderson7 @clemente-raposo @johnM2401