Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #154 - [Legacy] MySQL Error 1054: missing config.deleted columns #239

Merged
merged 1 commit into from Jun 7, 2023

Conversation

pgorod
Copy link
Contributor

@pgorod pgorod commented Mar 30, 2023

Description

Some modules don't have an SQL column that the code below expects.

Motivation and Context

See related Issue #154

Note that I am not sure which modules to add to the $excludedModules list I created. I know that the Administration module is the one causing the FATAL. Other modules could be added here later. I added a few that are "special" modules, without a DB table and a deleted column there.

How To Test This

I am not sure how to trigger it. I came across this in this Forum thread. It seems to happen somewhere along the way in the Campaign wizard.

Perhaps the best thing is to first try and reproduce the error, trigger it, and only then try the fix.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@SuiteBot
Copy link

SuiteBot commented Mar 30, 2023

CLA assistant check
All committers have signed the CLA.

@clemente-raposo clemente-raposo added Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Requires Testing Status: Passed Code Review labels May 22, 2023
@pgorod
Copy link
Contributor Author

pgorod commented May 29, 2023

This should really be merged ASAP, it keeps coming up in the Forums

Copy link

@johnM2401 johnM2401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to trigger initial issue occasionally through Admin modules & Campaign Wizard

Post-fix, no longer seeing these FATALs in the modules that I could previously replicate in

LGTM!

@clemente-raposo clemente-raposo merged commit 91b2a8a into salesagility:hotfix Jun 7, 2023
1 check passed
@pgorod pgorod deleted the patch-1 branch June 7, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Passed Code Review Status: Passed Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants