Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds extending option for the api bean mapper #243

Merged
merged 2 commits into from Jun 7, 2023
Merged

Adds extending option for the api bean mapper #243

merged 2 commits into from Jun 7, 2023

Conversation

eojedapilchik
Copy link
Contributor

@eojedapilchik eojedapilchik commented Apr 13, 2023 •
edited

Description

Adds the option to extend the ApiBeanMappers on the custom folder e.g:
public/legacy/custom/Extension/application/Ext/ApiBeanMappers/ModuleMappers/

Motivation and Context

This change allows extending the ApiBeanMappers using the extension framework.

How To Test This

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@eojedapilchik eojedapilchik changed the title Adds extending options for the api bean mapper Adds extending option for the api bean mapper Apr 13, 2023
@jack7anderson7 jack7anderson7 force-pushed the feature/add_extending_options_for_api_bean_mapper branch from 54fd719 to ceb1c34 Compare April 13, 2023 13:22
@jack7anderson7 jack7anderson7 added Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Requires Code Review labels Apr 13, 2023
clemente-raposo
clemente-raposo approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@clemente-raposo clemente-raposo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clemente-raposo clemente-raposo merged commit 55cda11 into salesagility:hotfix Jun 7, 2023
1 check passed
clemente-raposo pushed a commit that referenced this pull request Jun 7, 2023
@eojedapilchik @clemente-raposo
Fix #243 - Add api bean mappers to the extensions for extensibility
6812467
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clemente-raposo clemente-raposo clemente-raposo approved these changes

@johnM2401 johnM2401 johnM2401 approved these changes

Assignees
No one assigned
Labels
Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Passed Code Review Status: Passed Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eojedapilchik @clemente-raposo @johnM2401 @jack7anderson7