Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix query limit check for queries without limit on ListView record list #244

Merged
merged 1 commit into from Jun 7, 2023
Merged

Fix query limit check for queries without limit on ListView record list #244

merged 1 commit into from Jun 7, 2023

Conversation

eojedapilchik
Copy link
Contributor

Description

When using getList() method from RecordListHandler if you want to use no limit (limit = -2) the query will be filtered and no record will be returned

Motivation and Context

When using getList() method from RecordListHandler if you want to use no limit (limit = -2) the query will be filtered and no record will be returned, because ListDataPort has no check validation for limit < -1

How To Test This

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@eojedapilchik eojedapilchik changed the title Add extension file check on api bean mappers Fix query limit check for queries without limit for record list Apr 13, 2023
@eojedapilchik eojedapilchik changed the title Fix query limit check for queries without limit for record list Fix query limit check for queries without limit for ListView record list Apr 13, 2023
@eojedapilchik eojedapilchik changed the title Fix query limit check for queries without limit for ListView record list Fix query limit check for queries without limit on ListView record list Apr 13, 2023
@jack7anderson7 jack7anderson7 force-pushed the fix/query_limit_check_for_queries_without_limit_on_listview branch from 398fde4 to 44c346d Compare April 13, 2023 13:24
@jack7anderson7 jack7anderson7 added Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Requires Code Review labels Apr 13, 2023
clemente-raposo
clemente-raposo approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@clemente-raposo clemente-raposo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clemente-raposo clemente-raposo merged commit cce3b3e into salesagility:hotfix Jun 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clemente-raposo clemente-raposo clemente-raposo approved these changes

@johnM2401 johnM2401 johnM2401 approved these changes

Assignees
No one assigned
Labels
Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Passed Code Review Status: Passed Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eojedapilchik @clemente-raposo @johnM2401 @jack7anderson7