Update WebToPersonCapture.php fix #209 and #258 #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix salesagility#209 and salesagility#258 Was worked on PHP 7 and failed on PHP 8. Now works on both PHP 7 and PHP 8.
|
|
jack7anderson7
added
Status:Assessed
clemente-raposo
approved these changes
May 22, 2023
clemente-raposo
added
Status: Requires Testing
Status: Passed Code Review
and removed
Status: Requires Code Review
labels
|
LGTM |
johnM2401
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #209 and #258
Code had worked on PHP 7 and failed on PHP 8.
Now works on both PHP 7 and PHP 8.
Description
Motivation and Context
Web to Person form was failing with HTTP 500 error, code was incompatible with PHP 8.
How To Test This
Install and run Web to Person form on PHP 8 system, click submit, it will work.
Types of changes
Final checklist